Re: [Qemu-devel] [PATCH RFC v3 01/14] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

2017-01-21 Thread Peter Xu
On Fri, Jan 20, 2017 at 09:42:25AM -0600, Eric Blake wrote: > On 01/12/2017 09:06 PM, Peter Xu wrote: > > From: Aviv Ben-David > > Long subject line, please try to keep it around 60 or so characters > (look at 'git shortlog -30' for comparison). Also, fix the typos: >

Re: [Qemu-devel] [PATCH RFC v3 01/14] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

2017-01-20 Thread Eric Blake
On 01/12/2017 09:06 PM, Peter Xu wrote: > From: Aviv Ben-David Long subject line, please try to keep it around 60 or so characters (look at 'git shortlog -30' for comparison). Also, fix the typos: s/capility exposoed/capability exposed/ > > This capability asks the guest to

Re: [Qemu-devel] [PATCH RFC v3 01/14] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

2017-01-20 Thread Peter Xu
On Fri, Jan 20, 2017 at 09:20:01AM +, Tian, Kevin wrote: > > From: Peter Xu [mailto:pet...@redhat.com] > > Sent: Friday, January 20, 2017 5:12 PM > > > > On Fri, Jan 20, 2017 at 08:59:01AM +, Tian, Kevin wrote: > > > > [...] > > > > > > > Also for hot-add > > > > > device path, some

Re: [Qemu-devel] [PATCH RFC v3 01/14] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

2017-01-20 Thread Tian, Kevin
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Friday, January 20, 2017 5:12 PM > > On Fri, Jan 20, 2017 at 08:59:01AM +, Tian, Kevin wrote: > > [...] > > > > > Also for hot-add > > > > device path, some check of caching mode is required. If not set, > > > > should we fail hot-add

Re: [Qemu-devel] [PATCH RFC v3 01/14] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

2017-01-20 Thread Peter Xu
On Fri, Jan 20, 2017 at 08:59:01AM +, Tian, Kevin wrote: [...] > > > Also for hot-add > > > device path, some check of caching mode is required. If not set, > > > should we fail hot-add operation? I don't think we have such physical > > > platform with some devices behind IOMMU while others

Re: [Qemu-devel] [PATCH RFC v3 01/14] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

2017-01-20 Thread Tian, Kevin
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Friday, January 20, 2017 4:55 PM > > On Fri, Jan 20, 2017 at 08:32:06AM +, Tian, Kevin wrote: > > > From: Peter Xu [mailto:pet...@redhat.com] > > > Sent: Friday, January 13, 2017 11:06 AM > > > > > > From: Aviv Ben-David

Re: [Qemu-devel] [PATCH RFC v3 01/14] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

2017-01-20 Thread Peter Xu
On Fri, Jan 20, 2017 at 08:32:06AM +, Tian, Kevin wrote: > > From: Peter Xu [mailto:pet...@redhat.com] > > Sent: Friday, January 13, 2017 11:06 AM > > > > From: Aviv Ben-David > > > > This capability asks the guest to invalidate cache before each map > > operation. > >

Re: [Qemu-devel] [PATCH RFC v3 01/14] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

2017-01-20 Thread Tian, Kevin
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Friday, January 13, 2017 11:06 AM > > From: Aviv Ben-David > > This capability asks the guest to invalidate cache before each map operation. > We can use this invalidation to trap map operations in the hypervisor. > >