Re: [Qemu-devel] [PATCH RFC v5 2/7] ui/vnc.c: polish vnc_init_func

2018-10-12 Thread Fei Li
On 10/12/2018 06:23 PM, Fei Li wrote: On 10/12/2018 04:18 PM, Markus Armbruster wrote: Fei Li writes: On 10/11/2018 09:13 PM, Markus Armbruster wrote: Fei Li writes: Add a new Error parameter for vnc_display_init() to handle errors in its caller: vnc_init_func(), just like

Re: [Qemu-devel] [PATCH RFC v5 2/7] ui/vnc.c: polish vnc_init_func

2018-10-12 Thread Fei Li
On 10/12/2018 04:18 PM, Markus Armbruster wrote: Fei Li writes: On 10/11/2018 09:13 PM, Markus Armbruster wrote: Fei Li writes: Add a new Error parameter for vnc_display_init() to handle errors in its caller: vnc_init_func(), just like vnc_display_open() does. And let the call trace

Re: [Qemu-devel] [PATCH RFC v5 2/7] ui/vnc.c: polish vnc_init_func

2018-10-12 Thread Markus Armbruster
Fei Li writes: > On 10/11/2018 09:13 PM, Markus Armbruster wrote: >> Fei Li writes: >> >>> Add a new Error parameter for vnc_display_init() to handle errors >>> in its caller: vnc_init_func(), just like vnc_display_open() does. >>> And let the call trace propagate the Error. >>> >>> Besides,

Re: [Qemu-devel] [PATCH RFC v5 2/7] ui/vnc.c: polish vnc_init_func

2018-10-11 Thread Fei Li
On 10/11/2018 09:13 PM, Markus Armbruster wrote: Fei Li writes: Add a new Error parameter for vnc_display_init() to handle errors in its caller: vnc_init_func(), just like vnc_display_open() does. And let the call trace propagate the Error. Besides, make vnc_start_worker_thread() return a

Re: [Qemu-devel] [PATCH RFC v5 2/7] ui/vnc.c: polish vnc_init_func

2018-10-11 Thread Markus Armbruster
Fei Li writes: > Add a new Error parameter for vnc_display_init() to handle errors > in its caller: vnc_init_func(), just like vnc_display_open() does. > And let the call trace propagate the Error. > > Besides, make vnc_start_worker_thread() return a bool to indicate > whether it succeeds