Re: [Qemu-devel] [PATCH V7 1/4] rules: Move cross compilation auto detection functions to rules.mak

Laurent Vivier writes: > On 05/03/2018 18:59, Wei Huang wrote: > ... >> >> SLO build actually is OK if we don't move the cross-compile stuff to the >> generic rules.mak. >> >> So this cross-compile approach has lots of objection (unclean, broken >> rom build etc.). A

Re: [Qemu-devel] [PATCH V7 1/4] rules: Move cross compilation auto detection functions to rules.mak

On 05/03/2018 18:59, Wei Huang wrote: ... > > SLO build actually is OK if we don't move the cross-compile stuff to the > generic rules.mak. > > So this cross-compile approach has lots of objection (unclean, broken > rom build etc.). A complete solution will make this patchset bloated, > which is

Re: [Qemu-devel] [PATCH V7 1/4] rules: Move cross compilation auto detection functions to rules.mak

On 03/05/2018 07:52 AM, Dr. David Alan Gilbert wrote: > * Andrew Jones (drjo...@redhat.com) wrote: >> On Mon, Mar 05, 2018 at 11:01:23AM +, Dr. David Alan Gilbert wrote: >>> * Laurent Vivier (lviv...@redhat.com) wrote: On 28/02/2018 19:02, Wei Huang wrote: > This patch moves the

Re: [Qemu-devel] [PATCH V7 1/4] rules: Move cross compilation auto detection functions to rules.mak

* Andrew Jones (drjo...@redhat.com) wrote: > On Mon, Mar 05, 2018 at 11:01:23AM +, Dr. David Alan Gilbert wrote: > > * Laurent Vivier (lviv...@redhat.com) wrote: > > > On 28/02/2018 19:02, Wei Huang wrote: > > > > This patch moves the auto detection functions for cross compilation from > > > >

Re: [Qemu-devel] [PATCH V7 1/4] rules: Move cross compilation auto detection functions to rules.mak

On Mon, Mar 05, 2018 at 01:40:06PM +, Peter Maydell wrote: > On 5 March 2018 at 13:36, Andrew Jones wrote: > > IMO, the makefile is the right approach. I wouldn't like to see AArch64 > > added with a script and then converted, along with x86, to a makefile at > > some

Re: [Qemu-devel] [PATCH V7 1/4] rules: Move cross compilation auto detection functions to rules.mak

On 5 March 2018 at 13:36, Andrew Jones wrote: > IMO, the makefile is the right approach. I wouldn't like to see AArch64 > added with a script and then converted, along with x86, to a makefile at > some later time (probably never). I'm not really enthusiastic about this

Re: [Qemu-devel] [PATCH V7 1/4] rules: Move cross compilation auto detection functions to rules.mak

On Mon, Mar 05, 2018 at 11:01:23AM +, Dr. David Alan Gilbert wrote: > * Laurent Vivier (lviv...@redhat.com) wrote: > > On 28/02/2018 19:02, Wei Huang wrote: > > > This patch moves the auto detection functions for cross compilation from > > > roms/Makefile to rules.mak. So the functions can be

Re: [Qemu-devel] [PATCH V7 1/4] rules: Move cross compilation auto detection functions to rules.mak

* Laurent Vivier (lviv...@redhat.com) wrote: > On 28/02/2018 19:02, Wei Huang wrote: > > This patch moves the auto detection functions for cross compilation from > > roms/Makefile to rules.mak. So the functions can be shared among Makefiles > > in QEMU. > > > > Signed-off-by: Wei Huang

Re: [Qemu-devel] [PATCH V7 1/4] rules: Move cross compilation auto detection functions to rules.mak

On 28/02/2018 19:02, Wei Huang wrote: > This patch moves the auto detection functions for cross compilation from > roms/Makefile to rules.mak. So the functions can be shared among Makefiles > in QEMU. > > Signed-off-by: Wei Huang > Reviewed-by: Andrew Jones

Re: [Qemu-devel] [PATCH V7 1/4] rules: Move cross compilation auto detection functions to rules.mak

On 28/02/2018 19:02, Wei Huang wrote: > This patch moves the auto detection functions for cross compilation from > roms/Makefile to rules.mak. So the functions can be shared among Makefiles > in QEMU. > > Signed-off-by: Wei Huang > Reviewed-by: Andrew Jones