Re: [Qemu-devel] [PATCH for-2.8] docs: Fix description of the sentence
On 12/01/2016 08:59 PM, Zhang Chen wrote: > > > On 12/01/2016 10:57 PM, Eric Blake wrote: >> On 12/01/2016 12:55 AM, Zhang Chen wrote: >>> Say it in another way to make it easier to understand. >>> >>> Signed-off-by: Zhang Chen >>> Signed-off-by: Eric Blake >> I guess that's because I suggested the replacement text to use, even >> though I didn't write the patch. > > Yes, In that case, should I change the signed-off-by to acked-by or > remove it? I'm okay if you want to leave it as-is. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH for-2.8] docs: Fix description of the sentence
On 12/01/2016 10:57 PM, Eric Blake wrote: On 12/01/2016 12:55 AM, Zhang Chen wrote: Say it in another way to make it easier to understand. Signed-off-by: Zhang Chen Signed-off-by: Eric Blake I guess that's because I suggested the replacement text to use, even though I didn't write the patch. Yes, In that case, should I change the signed-off-by to acked-by or remove it? Thanks Zhang Chen At any rate, since this is doc-only, it's safe for inclusion in 2.8, if the maintainer wants to send a last-minute pull request (but if it misses the release, that's okay too) Signed-off-by: Stefan Weil --- docs/colo-proxy.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/colo-proxy.txt b/docs/colo-proxy.txt index 76767cb..c4941de 100644 --- a/docs/colo-proxy.txt +++ b/docs/colo-proxy.txt @@ -158,7 +158,9 @@ secondary. == Usage == -Here, we use demo ip and port discribe more clearly. +Here is an example using demonstration IP and port addresses to more +clearly describe the usage. + Primary(ip:3.3.3.3): -netdev tap,id=hn0,vhost=off,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown -device e1000,id=e0,netdev=hn0,mac=52:a4:00:12:78:66 -- Thanks zhangchen
Re: [Qemu-devel] [PATCH for-2.8] docs: Fix description of the sentence
On 12/01/2016 12:55 AM, Zhang Chen wrote: > Say it in another way to make it easier to understand. > > Signed-off-by: Zhang Chen > Signed-off-by: Eric Blake I guess that's because I suggested the replacement text to use, even though I didn't write the patch. At any rate, since this is doc-only, it's safe for inclusion in 2.8, if the maintainer wants to send a last-minute pull request (but if it misses the release, that's okay too) > Signed-off-by: Stefan Weil > --- > docs/colo-proxy.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/docs/colo-proxy.txt b/docs/colo-proxy.txt > index 76767cb..c4941de 100644 > --- a/docs/colo-proxy.txt > +++ b/docs/colo-proxy.txt > @@ -158,7 +158,9 @@ secondary. > > == Usage == > > -Here, we use demo ip and port discribe more clearly. > +Here is an example using demonstration IP and port addresses to more > +clearly describe the usage. > + > Primary(ip:3.3.3.3): > -netdev > tap,id=hn0,vhost=off,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown > -device e1000,id=e0,netdev=hn0,mac=52:a4:00:12:78:66 > -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
