Re: [Qemu-devel] [PATCH v1] s390x/tcg: add various alignment check

2018-02-14 Thread David Hildenbrand 
On 14.02.2018 17:05, Richard Henderson wrote:
> On 02/14/2018 07:25 AM, David Hildenbrand wrote:
>>  /* SET CLOCK COMPARATOR */
>> -C(0xb206, SCKC,S, Z,   0, m2_64, 0, 0, sckc, 0)
>> +C(0xb206, SCKC,S, Z,   0, a2, 0, 0, sckc, 0)
> 
> Rather than move the memory load into the op_ functions, better to add an
> m2_64a (etc) functions that apply the alignment.

Jup, also had that in mind, moves the magic to a different place. Will
play with it.

> 
> 
> r~
> 


-- 

Thanks,

David / dhildenb

Re: [Qemu-devel] [PATCH v1] s390x/tcg: add various alignment check

2018-02-14 Thread Richard Henderson 
On 02/14/2018 07:25 AM, David Hildenbrand wrote:
>  /* SET CLOCK COMPARATOR */
> -C(0xb206, SCKC,S, Z,   0, m2_64, 0, 0, sckc, 0)
> +C(0xb206, SCKC,S, Z,   0, a2, 0, 0, sckc, 0)

Rather than move the memory load into the op_ functions, better to add an
m2_64a (etc) functions that apply the alignment.


r~