- Original Message -
> From: "David Hildenbrand"
> To: "Claudio Imbrenda"
> Cc: "David Hildenbrand" , "Paolo Bonzini"
> , qemu-devel@nongnu.org
> Sent: Wednesday, October 12, 2016 8:38:15 PM
> Subject: Re: [Qemu-devel] [PATC
On Wed, Oct 12, 2016 at 03:55:18PM +0200, Claudio Imbrenda wrote:
> On 12/10/16 15:15, David Hildenbrand wrote:
> >>> +for (cx = 0; ccpus && ccpus[cx]; cx++) {
> >>> +cpu_single_step(cpu, 0);
> >
> > This looks suspicious
>
> why? we set all cpus to single step, since
On 12/10/2016 15:55, Claudio Imbrenda wrote:
>>> +for (cx = 0; ccpus && ccpus[cx]; cx++) {
>>> +cpu_single_step(cpu, 0);
>> >
>> > This looks suspicious
> why? we set all cpus to single step, since that is the default, and then
> we clear the single-step pro
On 12/10/16 15:15, David Hildenbrand wrote:
>>> +for (cx = 0; ccpus && ccpus[cx]; cx++) {
>>> +cpu_single_step(cpu, 0);
>
> This looks suspicious
why? we set all cpus to single step, since that is the default, and then
we clear the single-step property from all CPUs th
> > +if (def == 0) {
> > +for (cx = 0; scpus && scpus[cx]; cx++) {
> > +cpu_single_step(scpus[cx], sstep_flags);
> > +cpu_resume(scpus[cx]);
> > +}
> > +for (cx = 0; ccpus && ccpus[cx]; cx++) {
> > +cpu_resu
On 10/10/2016 13:50, Claudio Imbrenda wrote:
> +/*
> + * XXX vm_start also calls qemu_vmstop_requested(&requested); here,
> is
> + * it actually important? it's static in vl.c
> + */
Yes, it is, :) and so is qapi_event_send_resume (which is automatically
generate
