Re: [Qemu-devel] [PATCH v2] hw/i386: make IOMMUs configurable via default-configs/

2018-03-12 Thread Philippe Mathieu-Daudé
On 03/12/2018 10:43 AM, Paolo Bonzini wrote: > Allow distributions to disable the Intel and/or AMD IOMMU devices. > > Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé > --- > v1->v2: don't include x86-iommu.o unconditionally > >

Re: [Qemu-devel] [PATCH v2] hw/i386: make IOMMUs configurable via default-configs/

2018-03-12 Thread Thomas Huth
On 12.03.2018 10:53, Paolo Bonzini wrote: > On 12/03/2018 10:48, Thomas Huth wrote: >>> +obj-$(CONFIG_VTD) += x86-iommu.o intel_iommu.o >>> +obj-$(CONFIG_AMD_IOMMU) += x86-iommu.o amd_iommu.o >> The linker likely does not care if x86-iommu.o is included twice > > The linker actually cares, but

Re: [Qemu-devel] [PATCH v2] hw/i386: make IOMMUs configurable via default-configs/

2018-03-12 Thread Paolo Bonzini
On 12/03/2018 10:48, Thomas Huth wrote: >> +obj-$(CONFIG_VTD) += x86-iommu.o intel_iommu.o >> +obj-$(CONFIG_AMD_IOMMU) += x86-iommu.o amd_iommu.o > The linker likely does not care if x86-iommu.o is included twice The linker actually cares, but rules.mak drops the duplicate: commit

Re: [Qemu-devel] [PATCH v2] hw/i386: make IOMMUs configurable via default-configs/

2018-03-12 Thread Thomas Huth
On 12.03.2018 10:43, Paolo Bonzini wrote: > Allow distributions to disable the Intel and/or AMD IOMMU devices. > > Signed-off-by: Paolo Bonzini > --- > v1->v2: don't include x86-iommu.o unconditionally > > default-configs/i386-softmmu.mak | 2 ++ >