Re: [Qemu-devel] [PATCH v2] iotests: Test creating overlay when guest running
On 2017-12-25 03:51, Fam Zheng wrote: > Signed-off-by: Fam Zheng > > --- > > v2: Actually test the thing. [Kevin] > --- > tests/qemu-iotests/153 | 8 +--- > tests/qemu-iotests/153.out | 7 --- > 2 files changed, 9 insertions(+), 6 deletions(-) Thanks, applied to my block tree: https://github.com/XanClic/qemu/commits/block Max signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v2] iotests: Test creating overlay when guest running
On Wed, 02/14 09:26, Fam Zheng wrote: > Ping? Ping?
Re: [Qemu-devel] [PATCH v2] iotests: Test creating overlay when guest running
Ping? On Thu, Jan 4, 2018 at 6:18 AM, Eric Blake wrote: > On 12/24/2017 08:51 PM, Fam Zheng wrote: >> Signed-off-by: Fam Zheng >> >> --- >> >> v2: Actually test the thing. [Kevin] >> --- >> tests/qemu-iotests/153 | 8 +--- >> tests/qemu-iotests/153.out | 7 --- >> 2 files changed, 9 insertions(+), 6 deletions(-) > > Reviewed-by: Eric Blake > >> >> diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153 >> index fa25eb24bd..adfd02695b 100755 >> --- a/tests/qemu-iotests/153 >> +++ b/tests/qemu-iotests/153 >> @@ -32,6 +32,7 @@ _cleanup() >> { >> _cleanup_test_img >> rm -f "${TEST_IMG}.base" >> +rm -f "${TEST_IMG}.overlay" > > Trivial conflict with Jeff's work to do per-test temporary directories > in iotests. > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org >
Re: [Qemu-devel] [PATCH v2] iotests: Test creating overlay when guest running
On 12/24/2017 08:51 PM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > > --- > > v2: Actually test the thing. [Kevin] > --- > tests/qemu-iotests/153 | 8 +--- > tests/qemu-iotests/153.out | 7 --- > 2 files changed, 9 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake > > diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153 > index fa25eb24bd..adfd02695b 100755 > --- a/tests/qemu-iotests/153 > +++ b/tests/qemu-iotests/153 > @@ -32,6 +32,7 @@ _cleanup() > { > _cleanup_test_img > rm -f "${TEST_IMG}.base" > +rm -f "${TEST_IMG}.overlay" Trivial conflict with Jeff's work to do per-test temporary directories in iotests. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature