Re: [Qemu-devel] [PATCH v2] linux-user: Support f_flags in statfs when available.
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180219024555.26467-1-s...@shealevy.com Subject: [Qemu-devel] [PATCH v2] linux-user: Support f_flags in statfs when available. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base" # branch set -e echo "=== ENV ===" env echo "=== PACKAGES ===" rpm -qa echo "=== TEST BEGIN ===" CC=$HOME/bin/cc INSTALL=$PWD/install BUILD=$PWD/build echo -n "Using CC: " realpath $CC mkdir -p $BUILD $INSTALL SRC=$PWD cd $BUILD $SRC/configure --cc=$CC --prefix=$INSTALL make -j4 # XXX: we need reliable clean up # make check -j4 V=1 make install === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 3ad392fde0 linux-user: Support f_flags in statfs when available. === OUTPUT BEGIN === === ENV === LANG=en_US.UTF-8 XDG_SESSION_ID=68818 USER=fam PWD=/var/tmp/patchew-tester-tmp-6f3ncfs9/src HOME=/home/fam SHELL=/bin/sh SHLVL=2 PATCHEW=/home/fam/patchew/patchew-cli -s http://patchew.org --nodebug LOGNAME=fam DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1012/bus XDG_RUNTIME_DIR=/run/user/1012 PATH=/usr/bin:/bin _=/usr/bin/env === PACKAGES === gpg-pubkey-873529b8-54e386ff glibc-debuginfo-common-2.24-10.fc25.s390x fedora-release-26-1.noarch dejavu-sans-mono-fonts-2.35-4.fc26.noarch xemacs-filesystem-21.5.34-22.20170124hgf412e9f093d4.fc26.noarch bash-4.4.12-7.fc26.s390x freetype-2.7.1-9.fc26.s390x libSM-1.2.2-5.fc26.s390x libmpc-1.0.2-6.fc26.s390x libaio-0.3.110-7.fc26.s390x libverto-0.2.6-7.fc26.s390x perl-Scalar-List-Utils-1.48-1.fc26.s390x iptables-libs-1.6.1-2.fc26.s390x perl-threads-shared-1.57-1.fc26.s390x p11-kit-trust-0.23.9-2.fc26.s390x tcl-8.6.6-2.fc26.s390x libxshmfence-1.2-4.fc26.s390x expect-5.45-23.fc26.s390x perl-Thread-Queue-3.12-1.fc26.noarch perl-encoding-2.19-6.fc26.s390x keyutils-1.5.10-1.fc26.s390x gmp-devel-6.1.2-4.fc26.s390x enchant-1.6.0-16.fc26.s390x net-snmp-libs-5.7.3-17.fc26.s390x python-gobject-base-3.24.1-1.fc26.s390x python3-distro-1.0.3-1.fc26.noarch python3-enchant-1.6.10-1.fc26.noarch python-lockfile-0.11.0-6.fc26.noarch python2-pyparsing-2.1.10-3.fc26.noarch python2-lxml-4.1.1-1.fc26.s390x librados2-10.2.7-2.fc26.s390x trousers-lib-0.3.13-7.fc26.s390x libpaper-1.1.24-14.fc26.s390x libdatrie-0.2.9-4.fc26.s390x libsoup-2.58.2-1.fc26.s390x passwd-0.79-9.fc26.s390x bind99-libs-9.9.10-3.P3.fc26.s390x python3-rpm-4.13.0.2-1.fc26.s390x mock-core-configs-27.4-1.fc26.noarch systemd-233-7.fc26.s390x virglrenderer-0.6.0-1.20170210git76b3da97b.fc26.s390x s390utils-ziomon-1.36.1-3.fc26.s390x s390utils-osasnmpd-1.36.1-3.fc26.s390x libXrandr-1.5.1-2.fc26.s390x libglvnd-glx-1.0.0-1.fc26.s390x texlive-ifxetex-svn19685.0.5-33.fc26.2.noarch texlive-psnfss-svn33946.9.2a-33.fc26.2.noarch texlive-dvipdfmx-def-svn40328-33.fc26.2.noarch texlive-natbib-svn20668.8.31b-33.fc26.2.noarch texlive-xdvi-bin-svn40750-33.20160520.fc26.2.s390x texlive-cm-svn32865.0-33.fc26.2.noarch texlive-beton-svn15878.0-33.fc26.2.noarch texlive-fpl-svn15878.1.002-33.fc26.2.noarch texlive-mflogo-svn38628-33.fc26.2.noarch texlive-texlive-docindex-svn41430-33.fc26.2.noarch texlive-luaotfload-bin-svn34647.0-33.20160520.fc26.2.noarch texlive-koma-script-svn41508-33.fc26.2.noarch texlive-pst-tree-svn24142.1.12-33.fc26.2.noarch texlive-breqn-svn38099.0.98d-33.fc26.2.noarch texlive-xetex-svn41438-33.fc26.2.noarch gstreamer1-plugins-bad-free-1.12.3-1.fc26.s390x xorg-x11-font-utils-7.5-33.fc26.s390x ghostscript-fonts-5.50-36.fc26.noarch libXext-devel-1.3.3-5.fc26.s390x libusbx-devel-1.0.21-2.fc26.s390x libglvnd-devel-1.0.0-1.fc26.s390x emacs-25.3-3.fc26.s390x alsa-lib-devel-1.1.4.1-1.fc26.s390x kbd-2.0.4-2.fc26.s390x dconf-0.26.0-2.fc26.s390x ccache-3.3.4-1.fc26.s390x glibc-static-2.25-12.fc26.s390x mc-4.8.19-5.fc26.s390x doxygen-1.8.13-9.fc26.s390x dpkg-1.18.24-1.fc26.s390x libtdb-1.3.13-1.fc26.s390x python2-pynacl-1.1.1-1.fc26.s390x nss-sysinit-3.34.0-1.0.fc26.s390x kernel-4.13.16-202.fc26.s390x perl-Filter-1.58-1.fc26.s390x python2-pip-9.0.1-11.fc26.noarch dnf-2.7.5-2.fc26.noarch pcre2-utf16-10.23-11.fc26.s390x glusterfs-devel-3.10.8-1.fc26.s390x sssd-common-1.16.0-4.fc26.s390x python2-sssdconfig-1.16.0-4.fc26.noarch acpica-tools-20171110-1.fc26.s390x glibc-debuginfo-2.24-10.fc25.s390x fedora-repos-26-1.noarch dejavu-fonts-common-2.35-4.fc26.noarch bind99-license-9.9.10-3.P3.fc26.noarch ncurses-libs-6.0-8.20170212.fc26.s390x libpng-1.6.28-2.fc26.s390x libICE-1.0.9-9.fc26.s390x kmod-24-1.fc26.s390x libseccomp-2.3.2-1.fc26.s390x perl-Text-ParseWords-3.30-366.fc26.noarch libtool-ltdl-2.4.6-17.fc26.s390x perl-threads-2.16-1.fc26.s390x libselinux-utils-2.6-7.fc26.s390x userspace-rcu-0.9.3-2.fc26.s390x libXfont-1.5.2-5.fc26.s390x perl-Class-Inspector-1.31-3.fc26.noarch perl-open-1.10-395.fc26.noarch keyutils-libs-devel-1.5.10-1.fc26.s390x isl-0.16.1-1.fc26.s390x
Re: [Qemu-devel] [PATCH v2] linux-user: Support f_flags in statfs when available.
On Thu, 02/22 10:18, Shea Levy wrote: > Hello, > > These tabs match the existing style of linux-user/syscall.h, should I > remove them? > In practice, following the style of the surrounding code is usually preferred, and we ignore these errors in such cases. Fam
Re: [Qemu-devel] [PATCH v2] linux-user: Support f_flags in statfs when available.
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180219024555.26467-1-s...@shealevy.com Subject: [Qemu-devel] [PATCH v2] linux-user: Support f_flags in statfs when available. === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 3ad392fde0 linux-user: Support f_flags in statfs when available. === OUTPUT BEGIN === Checking PATCH 1/1: linux-user: Support f_flags in statfs when available ERROR: code indent should never use tabs #70: FILE: linux-user/syscall_defs.h:366: +^Iint f_frsize;$ ERROR: code indent should never use tabs #71: FILE: linux-user/syscall_defs.h:367: +^Iint f_flags;$ ERROR: code indent should never use tabs #72: FILE: linux-user/syscall_defs.h:368: +^Iint f_spare[4];$ ERROR: code indent should never use tabs #85: FILE: linux-user/syscall_defs.h:2234: +^Iint32_t^I^I^If_flags;$ ERROR: code indent should never use tabs #86: FILE: linux-user/syscall_defs.h:2235: +^Iint32_t^I^I^If_spare[5];$ ERROR: code indent should never use tabs #98: FILE: linux-user/syscall_defs.h:2255: +^Iabi_long^I^If_flags;$ ERROR: code indent should never use tabs #99: FILE: linux-user/syscall_defs.h:2256: +^Iabi_long^I^If_spare[5];$ ERROR: code indent should never use tabs #111: FILE: linux-user/syscall_defs.h:2276: +^Iuint32_t^If_flags;$ ERROR: code indent should never use tabs #112: FILE: linux-user/syscall_defs.h:2277: +^Iuint32_t^If_spare[5];$ ERROR: code indent should never use tabs #124: FILE: linux-user/syscall_defs.h:2297: +^Iabi_long f_flags;$ ERROR: code indent should never use tabs #125: FILE: linux-user/syscall_defs.h:2298: +^Iabi_long f_spare[4];$ ERROR: code indent should never use tabs #137: FILE: linux-user/syscall_defs.h:2316: +^Iabi_long f_flags;$ ERROR: code indent should never use tabs #138: FILE: linux-user/syscall_defs.h:2317: +^Iabi_long f_spare[4];$ ERROR: code indent should never use tabs #177: FILE: linux-user/syscall_defs.h:2374: +^Iuint32_t f_flags;$ ERROR: code indent should never use tabs #178: FILE: linux-user/syscall_defs.h:2375: +^Iuint32_t f_spare[4];$ ERROR: code indent should never use tabs #190: FILE: linux-user/syscall_defs.h:2393: +^Iuint32_t f_flags;$ ERROR: code indent should never use tabs #191: FILE: linux-user/syscall_defs.h:2394: +^Iuint32_t f_spare[4];$ total: 17 errors, 0 warnings, 164 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org
Re: [Qemu-devel] [PATCH v2] linux-user: Support f_flags in statfs when available.
Hello, These tabs match the existing style of linux-user/syscall.h, should I remove them? Also, there doesn't appear to be a maintainer for checkpatch in the current MAINTAINERS file, whom should I CC on this? Thanks, Shea no-re...@patchew.org writes: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20180219024555.26467-1-s...@shealevy.com > Subject: [Qemu-devel] [PATCH v2] linux-user: Support f_flags in statfs when > available. > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > 3ad392fde0 linux-user: Support f_flags in statfs when available. > > === OUTPUT BEGIN === > Checking PATCH 1/1: linux-user: Support f_flags in statfs when available > ERROR: code indent should never use tabs > #70: FILE: linux-user/syscall_defs.h:366: > +^Iint f_frsize;$ > > ERROR: code indent should never use tabs > #71: FILE: linux-user/syscall_defs.h:367: > +^Iint f_flags;$ > > ERROR: code indent should never use tabs > #72: FILE: linux-user/syscall_defs.h:368: > +^Iint f_spare[4];$ > > ERROR: code indent should never use tabs > #85: FILE: linux-user/syscall_defs.h:2234: > +^Iint32_t^I^I^If_flags;$ > > ERROR: code indent should never use tabs > #86: FILE: linux-user/syscall_defs.h:2235: > +^Iint32_t^I^I^If_spare[5];$ > > ERROR: code indent should never use tabs > #98: FILE: linux-user/syscall_defs.h:2255: > +^Iabi_long^I^If_flags;$ > > ERROR: code indent should never use tabs > #99: FILE: linux-user/syscall_defs.h:2256: > +^Iabi_long^I^If_spare[5];$ > > ERROR: code indent should never use tabs > #111: FILE: linux-user/syscall_defs.h:2276: > +^Iuint32_t^If_flags;$ > > ERROR: code indent should never use tabs > #112: FILE: linux-user/syscall_defs.h:2277: > +^Iuint32_t^If_spare[5];$ > > ERROR: code indent should never use tabs > #124: FILE: linux-user/syscall_defs.h:2297: > +^Iabi_long f_flags;$ > > ERROR: code indent should never use tabs > #125: FILE: linux-user/syscall_defs.h:2298: > +^Iabi_long f_spare[4];$ > > ERROR: code indent should never use tabs > #137: FILE: linux-user/syscall_defs.h:2316: > +^Iabi_long f_flags;$ > > ERROR: code indent should never use tabs > #138: FILE: linux-user/syscall_defs.h:2317: > +^Iabi_long f_spare[4];$ > > ERROR: code indent should never use tabs > #177: FILE: linux-user/syscall_defs.h:2374: > +^Iuint32_t f_flags;$ > > ERROR: code indent should never use tabs > #178: FILE: linux-user/syscall_defs.h:2375: > +^Iuint32_t f_spare[4];$ > > ERROR: code indent should never use tabs > #190: FILE: linux-user/syscall_defs.h:2393: > +^Iuint32_t f_flags;$ > > ERROR: code indent should never use tabs > #191: FILE: linux-user/syscall_defs.h:2394: > +^Iuint32_t f_spare[4];$ > > total: 17 errors, 0 warnings, 164 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-de...@freelists.org signature.asc Description: PGP signature
