Re: [Qemu-devel] [PATCH v2] qmp: add query-cpus-fast

2018-02-09 Thread Luiz Capitulino
On Fri, 9 Feb 2018 15:50:00 +0100 Viktor Mihajlovski wrote: > On 09.02.2018 15:27, Eduardo Habkost wrote: > [...] > >> I'm keeping it mainly for s390. Viktor, libvirt is still using > >> this field in s390, no? > >> > >> Dropping halted and having management software still using query-cpus > >> b

Re: [Qemu-devel] [PATCH v2] qmp: add query-cpus-fast

2018-02-09 Thread Viktor Mihajlovski
On 09.02.2018 15:27, Eduardo Habkost wrote: [...] >> I'm keeping it mainly for s390. Viktor, libvirt is still using >> this field in s390, no? >> >> Dropping halted and having management software still using query-cpus >> because of halted would be a total failure of query-cpus-fast. > > If I unde

Re: [Qemu-devel] [PATCH v2] qmp: add query-cpus-fast

2018-02-09 Thread Eduardo Habkost
On Fri, Feb 09, 2018 at 08:49:49AM -0500, Luiz Capitulino wrote: > On Fri, 9 Feb 2018 08:56:19 +0100 > Viktor Mihajlovski wrote: > > > On 08.02.2018 21:33, Eduardo Habkost wrote: > > > On Thu, Feb 08, 2018 at 11:17:32AM -0500, Luiz Capitulino wrote: > > > [...] > > >> The "halted" field is some

Re: [Qemu-devel] [PATCH v2] qmp: add query-cpus-fast

2018-02-09 Thread Viktor Mihajlovski
On 09.02.2018 14:49, Luiz Capitulino wrote: > On Fri, 9 Feb 2018 08:56:19 +0100 > Viktor Mihajlovski wrote: > >> On 08.02.2018 21:33, Eduardo Habkost wrote: >>> On Thu, Feb 08, 2018 at 11:17:32AM -0500, Luiz Capitulino wrote: >>> [...] The "halted" field is somewhat controversial. On the o

Re: [Qemu-devel] [PATCH v2] qmp: add query-cpus-fast

2018-02-09 Thread Luiz Capitulino
On Fri, 9 Feb 2018 08:56:19 +0100 Viktor Mihajlovski wrote: > On 08.02.2018 21:33, Eduardo Habkost wrote: > > On Thu, Feb 08, 2018 at 11:17:32AM -0500, Luiz Capitulino wrote: > > [...] > >> The "halted" field is somewhat controversial. On the one hand, > >> it offers a convenient way to know if

Re: [Qemu-devel] [PATCH v2] qmp: add query-cpus-fast

2018-02-08 Thread Viktor Mihajlovski
On 08.02.2018 21:33, Eduardo Habkost wrote: > On Thu, Feb 08, 2018 at 11:17:32AM -0500, Luiz Capitulino wrote: > [...] >> The "halted" field is somewhat controversial. On the one hand, >> it offers a convenient way to know if a guest CPU is idle or >> running. On the other hand, it's a field that c

Re: [Qemu-devel] [PATCH v2] qmp: add query-cpus-fast

2018-02-08 Thread Eduardo Habkost
On Thu, Feb 08, 2018 at 11:17:32AM -0500, Luiz Capitulino wrote: [...] > The "halted" field is somewhat controversial. On the one hand, > it offers a convenient way to know if a guest CPU is idle or > running. On the other hand, it's a field that can change many > times a second. In fact, the halte