Re: [Qemu-devel] [PATCH v2 07/14] pc: apic_common: extend APIC ID property to 32bit

2016-09-26 Thread Paolo Bonzini
On 26/09/2016 13:10, Igor Mammedov wrote: > On Thu, 22 Sep 2016 18:16:47 +0200 > Paolo Bonzini wrote: > >> On 22/09/2016 18:00, Igor Mammedov wrote: Why not just return initial_apic_id? This is the meaning the property had before your patch. >>> >>>

Re: [Qemu-devel] [PATCH v2 07/14] pc: apic_common: extend APIC ID property to 32bit

2016-09-26 Thread Igor Mammedov
On Thu, 22 Sep 2016 18:16:47 +0200 Paolo Bonzini wrote: > On 22/09/2016 18:00, Igor Mammedov wrote: > > > Why not just return initial_apic_id? This is the meaning the property > > > had before your patch. > > > > initial_apic_id is immutable but 'id' could be changed at

Re: [Qemu-devel] [PATCH v2 07/14] pc: apic_common: extend APIC ID property to 32bit

2016-09-22 Thread Paolo Bonzini
On 22/09/2016 18:00, Igor Mammedov wrote: > > Why not just return initial_apic_id? This is the meaning the property > > had before your patch. > > initial_apic_id is immutable but 'id' could be changed at runtime by guest in > xAPIC mode > so returned value depends on xAPIC/x2APIC mode

Re: [Qemu-devel] [PATCH v2 07/14] pc: apic_common: extend APIC ID property to 32bit

2016-09-22 Thread Igor Mammedov
On Thu, 22 Sep 2016 16:37:04 +0200 Paolo Bonzini wrote: > On 22/09/2016 14:50, Igor Mammedov wrote: > > ACPI ID is 32 bit wide on CPUs with x2APIC support. > > Extend 'id' property to support it. > > > > Signed-off-by: Igor Mammedov > > --- > >

Re: [Qemu-devel] [PATCH v2 07/14] pc: apic_common: extend APIC ID property to 32bit

2016-09-22 Thread Paolo Bonzini
On 22/09/2016 14:50, Igor Mammedov wrote: > ACPI ID is 32 bit wide on CPUs with x2APIC support. > Extend 'id' property to support it. > > Signed-off-by: Igor Mammedov > --- > include/hw/i386/apic_internal.h | 3 ++- > target-i386/cpu.h | 1 + >