Re: [Qemu-devel] [PATCH v2 09/34] tests/qgraph: pci-spapr driver and interface nodes

2018-08-10 Thread Paolo Bonzini
On 09/08/2018 15:19, Emanuele wrote: > > > On 08/09/2018 03:02 PM, Laurent Vivier wrote: >> On 06/08/2018 16:33, Emanuele Giuseppe Esposito wrote: >>> +void qpci_init_spapr(QPCIBusSPAPR *ret, QTestState *qts, >>> QGuestAllocator *alloc) >>> +{ >>>   assert(qts); >>>   +    /* tests cannot use

Re: [Qemu-devel] [PATCH v2 09/34] tests/qgraph: pci-spapr driver and interface nodes

2018-08-09 Thread Emanuele
On 08/09/2018 03:02 PM, Laurent Vivier wrote: On 06/08/2018 16:33, Emanuele Giuseppe Esposito wrote: +void qpci_init_spapr(QPCIBusSPAPR *ret, QTestState *qts, QGuestAllocator *alloc) +{ assert(qts); +/* tests cannot use spapr, needs to be fixed first */ +ret->bus.has_buggy_

Re: [Qemu-devel] [PATCH v2 09/34] tests/qgraph: pci-spapr driver and interface nodes

2018-08-09 Thread Laurent Vivier
On 06/08/2018 16:33, Emanuele Giuseppe Esposito wrote: > +void qpci_init_spapr(QPCIBusSPAPR *ret, QTestState *qts, QGuestAllocator > *alloc) > +{ > assert(qts); > > +/* tests cannot use spapr, needs to be fixed first */ > +ret->bus.has_buggy_msi = TRUE; > + Perhaps you can revert t

Re: [Qemu-devel] [PATCH v2 09/34] tests/qgraph: pci-spapr driver and interface nodes

2018-08-09 Thread Laurent Vivier
On 06/08/2018 16:33, Emanuele Giuseppe Esposito wrote: > Add pci-bus-spapr node, that produces pci-bus. Move QPCIBusSPAPR struct > declaration in its header (since it will be needed by other drivers) > and introduce a setter method for drivers that do not need to allocate > but have to initialize Q