On 2018-03-13 12:58, Fam Zheng wrote: > Reopen flags are not synchronized according to the > bdrv_reopen_queue_child precedence until bdrv_reopen_prepare. It is a > bit too late: we already check the consistency in bdrv_check_perm before > that. > > This fixes the bug that when bdrv_reopen a RO node as RW, the flags for > backing child are wrong. Before, we could recurse with flags.rw=1; now, > role->inherit_options + update_flags_from_options will make sure to > clear the bit when necessary. Note that this will not clear an > explicitly set bit, as in the case of parallel block jobs (e.g. > test_stream_parallel in 030), because the explicit options include > 'read-only=false' (for an intermediate node used by a different job). > > Signed-off-by: Fam Zheng <f...@redhat.com> > --- > block.c | 7 +++++++ > 1 file changed, 7 insertions(+)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
