Re: [Qemu-devel] [PATCH v2 1/2] ipmi: Use proper struct reference for KCS vmstate

2018-04-24 Thread Corey Minyard
On 04/24/2018 10:32 AM, Dr. David Alan Gilbert wrote: * Corey Minyard (miny...@acm.org) wrote: On 03/05/2018 08:09 AM, Dr. David Alan Gilbert wrote: * miny...@acm.org (miny...@acm.org) wrote: From: Corey Minyard The vmstate for isa_ipmi_kcs was referencing into the kcs

Re: [Qemu-devel] [PATCH v2 1/2] ipmi: Use proper struct reference for KCS vmstate

2018-04-24 Thread Dr. David Alan Gilbert
* Corey Minyard (miny...@acm.org) wrote: > On 03/05/2018 08:09 AM, Dr. David Alan Gilbert wrote: > > * miny...@acm.org (miny...@acm.org) wrote: > > > From: Corey Minyard > > > > > > The vmstate for isa_ipmi_kcs was referencing into the kcs structure, > > > instead create a

Re: [Qemu-devel] [PATCH v2 1/2] ipmi: Use proper struct reference for KCS vmstate

2018-03-06 Thread Corey Minyard
On 03/05/2018 04:52 PM, Corey Minyard wrote: On 03/05/2018 08:09 AM, Dr. David Alan Gilbert wrote: * miny...@acm.org (miny...@acm.org) wrote: From: Corey Minyard The vmstate for isa_ipmi_kcs was referencing into the kcs structure, instead create a kcs structure separate

Re: [Qemu-devel] [PATCH v2 1/2] ipmi: Use proper struct reference for KCS vmstate

2018-03-05 Thread Corey Minyard
On 03/05/2018 08:09 AM, Dr. David Alan Gilbert wrote: * miny...@acm.org (miny...@acm.org) wrote: From: Corey Minyard The vmstate for isa_ipmi_kcs was referencing into the kcs structure, instead create a kcs structure separate and use that. There were also some issues in

Re: [Qemu-devel] [PATCH v2 1/2] ipmi: Use proper struct reference for KCS vmstate

2018-03-05 Thread Dr. David Alan Gilbert
* miny...@acm.org (miny...@acm.org) wrote: > From: Corey Minyard > > The vmstate for isa_ipmi_kcs was referencing into the kcs structure, > instead create a kcs structure separate and use that. > > There were also some issues in the state transfer. The inlen field > was