On Wed 17 Jan 2018 05:57:32 PM CET, Anton Nefedov wrote:
> On 17/1/2018 6:42 PM, Alberto Garcia wrote:
>> On Tue 16 Jan 2018 05:52:36 PM CET, Anton Nefedov wrote:
>>>
>>> Cosmetic: maybe this l2_load() better be merged with the copied L2 case?
>>> e.g.
>>>
>>> if (!(l1_table[l1_index] &
On 17/1/2018 6:42 PM, Alberto Garcia wrote:
On Tue 16 Jan 2018 05:52:36 PM CET, Anton Nefedov wrote:
Cosmetic: maybe this l2_load() better be merged with the copied L2 case?
e.g.
if (!(l1_table[l1_index] & COPIED))
l2_allocate();
l2_load();
I'm not sure about that, since
On Wed 17 Jan 2018 05:06:04 PM CET, Eric Blake wrote:
/* allocate a new entry in the l2 cache */
+slice_size = s->l2_slice_size * sizeof(uint64_t);
>>>
>>> Would this read any better if the earlier patch named it
>>> s->l2_slice_entries?
>>
>> I had doubts with this.
On Tue 16 Jan 2018 11:26:40 PM CET, Eric Blake wrote:
>> /* allocate a new entry in the l2 cache */
>>
>> +slice_size = s->l2_slice_size * sizeof(uint64_t);
>
> Would this read any better if the earlier patch named it
> s->l2_slice_entries?
I had doubts with this. Like you, when I see
On 01/17/2018 09:55 AM, Alberto Garcia wrote:
> On Tue 16 Jan 2018 11:26:40 PM CET, Eric Blake wrote:
>>> /* allocate a new entry in the l2 cache */
>>>
>>> +slice_size = s->l2_slice_size * sizeof(uint64_t);
>>
>> Would this read any better if the earlier patch named it
>>
On Tue 16 Jan 2018 05:52:36 PM CET, Anton Nefedov wrote:
>> @@ -299,42 +300,50 @@ static int l2_allocate(BlockDriverState *bs, int
>> l1_index, uint64_t **table)
>>
> [..]>
>> -/* write the l2 table to the file */
>> -BLKDBG_EVENT(bs->file, BLKDBG_L2_ALLOC_WRITE);
>> +
On 12/15/2017 06:53 AM, Alberto Garcia wrote:
> This patch updates l2_allocate() to support the qcow2 cache returning
> L2 slices instead of full L2 tables.
>
> The old code simply gets an L2 table from the cache and initializes it
> with zeroes or with the contents of an existing table. With a
On 15/12/2017 3:53 PM, Alberto Garcia wrote:
This patch updates l2_allocate() to support the qcow2 cache returning
L2 slices instead of full L2 tables.
The old code simply gets an L2 table from the cache and initializes it
with zeroes or with the contents of an existing table. With a cache
