On 09/22/2016 03:13 AM, Alex Bennée wrote:
This is to appease sanitizer builds which complain that:

  "error: control reaches end of non-void function"

Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
---
 tcg/optimize.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tcg/optimize.c b/tcg/optimize.c
index 9998ac7..0f13490 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -468,9 +468,8 @@ static TCGArg do_constant_folding_cond(TCGOpcode op, TCGArg 
x,
         default:
             return 2;
         }
-    } else {
-        return 2;
     }
+    return 2;

I'm disappointed that the sanitizer doesn't see the abort above as a noreturn. That said, this isn't wrong so,

Reviewed-by: Richard Henderson <r...@twiddle.net>


r~


Reply via email to