Re: [Qemu-devel] [PATCH v2 20/28] s390x/tcg: OC: Fault-safe handling

2019-09-16 Thread David Hildenbrand 
On 11.09.19 23:26, Richard Henderson wrote:
> On 9/6/19 3:57 AM, David Hildenbrand wrote:
>> +srca2 = access_prepare(env, dest, l, MMU_DATA_LOAD, ra);
>> +desta = access_prepare(env, dest, l, MMU_DATA_STORE, ra);
> 
> We should find a way to perform this in one step.
> RWM isn't uncommon...

Yes, like converting MMU_* into flags we can then process in probe_access().

> 
> That said,
> Reviewed-by: Richard Henderson 
> 
> r~
> 


-- 

Thanks,

David / dhildenb

Re: [Qemu-devel] [PATCH v2 20/28] s390x/tcg: OC: Fault-safe handling

2019-09-11 Thread Richard Henderson 
On 9/6/19 3:57 AM, David Hildenbrand wrote:
> +srca2 = access_prepare(env, dest, l, MMU_DATA_LOAD, ra);
> +desta = access_prepare(env, dest, l, MMU_DATA_STORE, ra);

We should find a way to perform this in one step.
RWM isn't uncommon...

That said,
Reviewed-by: Richard Henderson 

r~