Re: [Qemu-devel] [PATCH v2 20/36] rbd: Remove non-schema options from runtime_opts
On 2018-02-23 00:13, Max Reitz wrote: > On 2018-02-21 14:53, Kevin Wolf wrote: >> Instead of the QemuOpts in qemu_rbd_connect(), we want to use QAPI >> objects. As a preparation, fetch those options directly from the QDict >> that .bdrv_open() supports in the rbd driver and that are not in the >> schema. >> >> Signed-off-by: Kevin Wolf>> --- >> block/rbd.c | 55 --- >> 1 file changed, 24 insertions(+), 31 deletions(-) >> >> diff --git a/block/rbd.c b/block/rbd.c >> index 4bbcce4eca..2e79c2d1fd 100644 >> --- a/block/rbd.c >> +++ b/block/rbd.c >> @@ -326,28 +326,6 @@ static QemuOptsList runtime_opts = { >> /* >> * server.* extracted manually, see qemu_rbd_mon_host() >> */ >> -{ >> -.name = "password-secret", >> -.type = QEMU_OPT_STRING, >> -.help = "ID of secret providing the password", >> -}, > > Err, did we just forget this in the QAPI schema or is it really not > supposed to be there? Ah, we intentionally removed it after it was added. OK, then. Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v2 20/36] rbd: Remove non-schema options from runtime_opts
On 2018-02-21 14:53, Kevin Wolf wrote: > Instead of the QemuOpts in qemu_rbd_connect(), we want to use QAPI > objects. As a preparation, fetch those options directly from the QDict > that .bdrv_open() supports in the rbd driver and that are not in the > schema. > > Signed-off-by: Kevin Wolf> --- > block/rbd.c | 55 --- > 1 file changed, 24 insertions(+), 31 deletions(-) > > diff --git a/block/rbd.c b/block/rbd.c > index 4bbcce4eca..2e79c2d1fd 100644 > --- a/block/rbd.c > +++ b/block/rbd.c > @@ -326,28 +326,6 @@ static QemuOptsList runtime_opts = { > /* > * server.* extracted manually, see qemu_rbd_mon_host() > */ > -{ > -.name = "password-secret", > -.type = QEMU_OPT_STRING, > -.help = "ID of secret providing the password", > -}, Err, did we just forget this in the QAPI schema or is it really not supposed to be there? Max signature.asc Description: OpenPGP digital signature