Re: [Qemu-devel] [PATCH v2 27/36] sheepdog: QAPIfy "redundacy" create option

2018-02-23 Thread Kevin Wolf 
Am 21.02.2018 um 14:53 hat Kevin Wolf geschrieben:
> The "redundacy" option for Sheepdog image creation is currently a string
> that can encode one or two integers depending on its format, which at
> the same time implicitly selects a mode.
> 
> This patch turns it into a QAPI union and converts the string into such
> a QAPI object before interpreting the values.
> 
> Signed-off-by: Kevin Wolf 

s/redundacy/redundancy/

Both in the subject line and the commit message. Autocompletion is
great, it helps to apply typos consistently.

Kevin

Re: [Qemu-devel] [PATCH v2 27/36] sheepdog: QAPIfy "redundacy" create option

2018-02-22 Thread Max Reitz 
On 2018-02-21 14:53, Kevin Wolf wrote:
> The "redundacy" option for Sheepdog image creation is currently a string
> that can encode one or two integers depending on its format, which at
> the same time implicitly selects a mode.
> 
> This patch turns it into a QAPI union and converts the string into such
> a QAPI object before interpreting the values.
> 
> Signed-off-by: Kevin Wolf 
> ---
>  qapi/block-core.json | 45 +
>  block/sheepdog.c | 94 
> +---
>  2 files changed, 112 insertions(+), 27 deletions(-)

Ooooh, thanks!

Reviewed-by: Max Reitz 



signature.asc
Description: OpenPGP digital signature