Re: [Qemu-devel] [PATCH v2 29/34] test/qgraph: virtio-blk test node

2018-08-10 Thread Laurent Vivier 
On 10/08/2018 11:45, Emanuele wrote:
> On 08/09/2018 04:16 PM, Laurent Vivier wrote:
>> On 06/08/2018 16:34, Emanuele Giuseppe Esposito wrote:
>>> -static void mmio_basic(void)
>>> +static void basic_resize(void *obj, void *data, QGuestAllocator
>>> *t_alloc)
>>>   {
>>> -    QVirtioMMIODevice *dev;
>>> -    QVirtQueue *vq;
>>> -    QGuestAllocator *alloc;
>>> +    QVirtioBlk *blk_if = obj;
>>> +    QVirtioDevice *dev = blk_if->vdev;
>>>   int n_size = TEST_IMAGE_SIZE / 2;
>>>   uint64_t capacity;
>>> +    QVirtQueue *vq;
>>>   -    arm_test_start();
>>> -
>>> -    dev = qvirtio_mmio_device_new(MMIO_DEV_BASE_ADDR, MMIO_PAGE_SIZE);
>> This is the only user of qvirtio_mmio_device_new(), so if you remove the
>> call here, you could also remove the function definition.
> So you suggest to get rid completely of qvirtio_mmio_device_new() in
> virtio-mmio.c  ?

Yes.

> Couldn't it be useful in future maybe?

We'll be able to use qvirtio_mmio_init_device() instead, so I don't
think it's a problem.

Thanks,
Laurent

Re: [Qemu-devel] [PATCH v2 29/34] test/qgraph: virtio-blk test node

2018-08-10 Thread Emanuele 

On 08/09/2018 04:16 PM, Laurent Vivier wrote:

On 06/08/2018 16:34, Emanuele Giuseppe Esposito wrote:

-static void mmio_basic(void)
+static void basic_resize(void *obj, void *data, QGuestAllocator *t_alloc)
  {
-QVirtioMMIODevice *dev;
-QVirtQueue *vq;
-QGuestAllocator *alloc;
+QVirtioBlk *blk_if = obj;
+QVirtioDevice *dev = blk_if->vdev;
  int n_size = TEST_IMAGE_SIZE / 2;
  uint64_t capacity;
+QVirtQueue *vq;
  
-arm_test_start();

-
-dev = qvirtio_mmio_device_new(MMIO_DEV_BASE_ADDR, MMIO_PAGE_SIZE);

This is the only user of qvirtio_mmio_device_new(), so if you remove the
call here, you could also remove the function definition.
So you suggest to get rid completely of qvirtio_mmio_device_new() in 
virtio-mmio.c  ?

Couldn't it be useful in future maybe?

Emanuele

Re: [Qemu-devel] [PATCH v2 29/34] test/qgraph: virtio-blk test node

2018-08-09 Thread Laurent Vivier 
On 06/08/2018 16:34, Emanuele Giuseppe Esposito wrote:
> -static void mmio_basic(void)
> +static void basic_resize(void *obj, void *data, QGuestAllocator *t_alloc)
>  {
> -QVirtioMMIODevice *dev;
> -QVirtQueue *vq;
> -QGuestAllocator *alloc;
> +QVirtioBlk *blk_if = obj;
> +QVirtioDevice *dev = blk_if->vdev;
>  int n_size = TEST_IMAGE_SIZE / 2;
>  uint64_t capacity;
> +QVirtQueue *vq;
>  
> -arm_test_start();
> -
> -dev = qvirtio_mmio_device_new(MMIO_DEV_BASE_ADDR, MMIO_PAGE_SIZE);

This is the only user of qvirtio_mmio_device_new(), so if you remove the
call here, you could also remove the function definition.

Thanks,
Laurent