Re: [Qemu-devel] [PATCH v2 3/3] Update Documentation
On Wed, 26 Feb 2020 23:59:22 +0800 Jing-Wei Su wrote: > Hi, Lukas > > If PVM died, to let old SVM be the new PVM, the old SVM's > filter-redirectors(f1 and f2) are removed in your document. > Why don't you remove the filter-rewriter from the old SVM? > The filter-rewrite is kept in the new PVM. What is its role in the new PVM? > > Thanks! > > Sincerely, > Jing-Wei Hi, The filter-rewriter rewrites the TCP-Packets to increase similarity of PVM and SVM, after the SVM takes over it needs to continue the rewriting, otherwise it would break the TCP connections. Regards, Lukas Straub
Re: [Qemu-devel] [PATCH v2 3/3] Update Documentation
Hi, Lukas If PVM died, to let old SVM be the new PVM, the old SVM's filter-redirectors(f1 and f2) are removed in your document. Why don't you remove the filter-rewriter from the old SVM? The filter-rewrite is kept in the new PVM. What is its role in the new PVM? Thanks! Sincerely, Jing-Wei
Re: [Qemu-devel] [PATCH v2 3/3] Update Documentation
On Mon, 2 Sep 2019 12:17:43 + "Zhang, Chen" wrote: > Hi Lukas, > > Please address Markus's comments change this patch's name in next version. > And I wrote some comments behind, please check it. > Firstly, Please remove all the trailing whitespace in this patch. > > > > -Original Message- > > From: Lukas Straub > > Sent: Friday, August 16, 2019 2:49 AM > > To: qemu-devel > > Cc: Zhang, Chen ; Jason Wang > > ; Wen Congyang ; > > Xie Changlong > > Subject: [PATCH v2 3/3] Update Documentation > > > > Document the qemu command-line and qmp commands for continious > > replication > > > > Signed-off-by: Lukas Straub > > --- > > docs/COLO-FT.txt | 185 +++ > > > > 1 file changed, 138 insertions(+), 47 deletions(-) > > > > diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt index > > ad24680d13..c08bfbd3a8 100644 > > --- a/docs/COLO-FT.txt > > +++ b/docs/COLO-FT.txt > > @@ -145,35 +145,64 @@ The diagram just shows the main qmp command, > > you can get the detail in test procedure. > > > > == Test procedure == > > +Note: Here we are running both instances on the same Machine for > > +testing, change the IP Addresses if you want to run it on two Hosts > > + > > 1. Startup qemu > > Primary: > > -# qemu-system-x86_64 -accel kvm -m 2048 -smp 2 -qmp stdio -name > > primary \ > > - -device piix3-usb-uhci -vnc :7 \ > > - -device usb-tablet -netdev tap,id=hn0,vhost=off \ > > - -device virtio-net-pci,id=net-pci0,netdev=hn0 \ > > - -drive if=virtio,id=primary-disk0,driver=quorum,read-pattern=fifo,vote- > > threshold=1,\ > > - children.0.file.filename=1.raw,\ > > - children.0.driver=raw -S > > +# imagefolder="/mnt/vms/colo-test" > > + > > +# cp --reflink=auto $imagefolder/primary.qcow2 > > +$imagefolder/primary-copy.qcow2 > > I think you can tell other people here that we need two same disk image > before COLO startup. > The name "primary and primary-copy" will make reader very confused. > > > + > > +# qemu-system-x86_64 -enable-kvm -cpu qemu64,+kvmclock -m 512 -smp > > 1 -qmp stdio \ > > + -vnc :0 -k de -device piix3-usb-uhci -device usb-tablet -name primary \ > > > > What's mean of the "-k de" ? Hi, Oops, thats for German Keyboard layout, will remove. > > + -netdev tap,id=hn0,vhost=off,helper=/usr/lib/qemu/qemu-bridge-helper > > \ > > + -device rtl8139,id=e0,netdev=hn0 \ > > + -chardev socket,id=mirror0,host=127.0.0.1,port=9003,server,nowait \ > > + -chardev socket,id=compare1,host=127.0.0.1,port=9004,server,wait \ > > + -chardev socket,id=compare0,host=127.0.0.1,port=9001,server,nowait \ > > + -chardev socket,id=compare0-0,host=127.0.0.1,port=9001 \ > > + -chardev socket,id=compare_out,host=127.0.0.1,port=9005,server,nowait > > \ > > + -chardev socket,id=compare_out0,host=127.0.0.1,port=9005 \ > > + -object filter-mirror,id=m0,netdev=hn0,queue=tx,outdev=mirror0 \ > > + -object filter- > > redirector,netdev=hn0,id=redire0,queue=rx,indev=compare_out \ > > + -object filter- > > redirector,netdev=hn0,id=redire1,queue=rx,outdev=compare0 \ > > + -object iothread,id=iothread1 \ > > + -object > > +colo-compare,id=comp0,primary_in=compare0- > > 0,secondary_in=compare1,\ > > +outdev=compare_out0,iothread=iothread1 \ > > Please keep the space style. > > > + -drive > > +if=ide,id=colo-disk0,driver=quorum,read-pattern=fifo,vote-threshold=1,\ > > +children.0.file.filename=$imagefolder/primary.qcow2,children.0.driver=q > > +cow2 -S > > + > > Secondary: > > -# qemu-system-x86_64 -accel kvm -m 2048 -smp 2 -qmp stdio -name > > secondary \ > > - -device piix3-usb-uhci -vnc :7 \ > > - -device usb-tablet -netdev tap,id=hn0,vhost=off \ > > - -device virtio-net-pci,id=net-pci0,netdev=hn0 \ > > - -drive if=none,id=secondary-disk0,file.filename=1.raw,driver=raw,node- > > name=node0 \ > > - -drive if=virtio,id=active-disk0,driver=replication,mode=secondary,\ > > - file.driver=qcow2,top-id=active-disk0,\ > > - file.file.filename=/mnt/ramfs/active_disk.img,\ > > - file.backing.driver=qcow2,\ > > - file.backing.file.filename=/mnt/ramfs/hidden_disk.img,\ > > - file.backing.backing=secondary-disk0 \ > > - -incoming tcp:0: > > +# imagefolder="/mnt/vms/colo-test" > > + > > +# qemu-img create -f qcow2 $imagefolder/secondary-active.qcow2 10G > > + > > +# qemu-img create -f qcow2 $imagefolder/secondary-hidden.qcow2 10G > > + > > +# qemu-system-x86_64 -enable-kvm -cpu qemu64,+kvmclock -m 512 -smp > > 1 -qmp stdio \ > > + -vnc :1 -k de -device piix3-usb-uhci -device usb-tablet -name secondary > > \ > > + -netdev tap,id=hn0,vhost=off,helper=/usr/lib/qemu/qemu-bridge-helper > > \ > > + -device rtl8139,id=e0,netdev=hn0 \ > > + -chardev socket,id=red0,host=127.0.0.1,port=9003,reconnect=1 \ > > + -chardev socket,id=red1,host=127.0.0.1,port=9004,reconnect=1 \ > > + -object filter-redirector,id=f1,netdev=hn0,queue=tx,indev=red0 \ > > + -object
Re: [Qemu-devel] [PATCH v2 3/3] Update Documentation
Hi Lukas, Please address Markus's comments change this patch's name in next version. And I wrote some comments behind, please check it. Firstly, Please remove all the trailing whitespace in this patch. > -Original Message- > From: Lukas Straub > Sent: Friday, August 16, 2019 2:49 AM > To: qemu-devel > Cc: Zhang, Chen ; Jason Wang > ; Wen Congyang ; > Xie Changlong > Subject: [PATCH v2 3/3] Update Documentation > > Document the qemu command-line and qmp commands for continious > replication > > Signed-off-by: Lukas Straub > --- > docs/COLO-FT.txt | 185 +++ > > 1 file changed, 138 insertions(+), 47 deletions(-) > > diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt index > ad24680d13..c08bfbd3a8 100644 > --- a/docs/COLO-FT.txt > +++ b/docs/COLO-FT.txt > @@ -145,35 +145,64 @@ The diagram just shows the main qmp command, > you can get the detail in test procedure. > > == Test procedure == > +Note: Here we are running both instances on the same Machine for > +testing, change the IP Addresses if you want to run it on two Hosts > + > 1. Startup qemu > Primary: > -# qemu-system-x86_64 -accel kvm -m 2048 -smp 2 -qmp stdio -name > primary \ > - -device piix3-usb-uhci -vnc :7 \ > - -device usb-tablet -netdev tap,id=hn0,vhost=off \ > - -device virtio-net-pci,id=net-pci0,netdev=hn0 \ > - -drive if=virtio,id=primary-disk0,driver=quorum,read-pattern=fifo,vote- > threshold=1,\ > - children.0.file.filename=1.raw,\ > - children.0.driver=raw -S > +# imagefolder="/mnt/vms/colo-test" > + > +# cp --reflink=auto $imagefolder/primary.qcow2 > +$imagefolder/primary-copy.qcow2 I think you can tell other people here that we need two same disk image before COLO startup. The name "primary and primary-copy" will make reader very confused. > + > +# qemu-system-x86_64 -enable-kvm -cpu qemu64,+kvmclock -m 512 -smp > 1 -qmp stdio \ > + -vnc :0 -k de -device piix3-usb-uhci -device usb-tablet -name primary \ What's mean of the "-k de" ? > + -netdev tap,id=hn0,vhost=off,helper=/usr/lib/qemu/qemu-bridge-helper > \ > + -device rtl8139,id=e0,netdev=hn0 \ > + -chardev socket,id=mirror0,host=127.0.0.1,port=9003,server,nowait \ > + -chardev socket,id=compare1,host=127.0.0.1,port=9004,server,wait \ > + -chardev socket,id=compare0,host=127.0.0.1,port=9001,server,nowait \ > + -chardev socket,id=compare0-0,host=127.0.0.1,port=9001 \ > + -chardev socket,id=compare_out,host=127.0.0.1,port=9005,server,nowait > \ > + -chardev socket,id=compare_out0,host=127.0.0.1,port=9005 \ > + -object filter-mirror,id=m0,netdev=hn0,queue=tx,outdev=mirror0 \ > + -object filter- > redirector,netdev=hn0,id=redire0,queue=rx,indev=compare_out \ > + -object filter- > redirector,netdev=hn0,id=redire1,queue=rx,outdev=compare0 \ > + -object iothread,id=iothread1 \ > + -object > +colo-compare,id=comp0,primary_in=compare0- > 0,secondary_in=compare1,\ > +outdev=compare_out0,iothread=iothread1 \ Please keep the space style. > + -drive > +if=ide,id=colo-disk0,driver=quorum,read-pattern=fifo,vote-threshold=1,\ > +children.0.file.filename=$imagefolder/primary.qcow2,children.0.driver=q > +cow2 -S > + > Secondary: > -# qemu-system-x86_64 -accel kvm -m 2048 -smp 2 -qmp stdio -name > secondary \ > - -device piix3-usb-uhci -vnc :7 \ > - -device usb-tablet -netdev tap,id=hn0,vhost=off \ > - -device virtio-net-pci,id=net-pci0,netdev=hn0 \ > - -drive if=none,id=secondary-disk0,file.filename=1.raw,driver=raw,node- > name=node0 \ > - -drive if=virtio,id=active-disk0,driver=replication,mode=secondary,\ > - file.driver=qcow2,top-id=active-disk0,\ > - file.file.filename=/mnt/ramfs/active_disk.img,\ > - file.backing.driver=qcow2,\ > - file.backing.file.filename=/mnt/ramfs/hidden_disk.img,\ > - file.backing.backing=secondary-disk0 \ > - -incoming tcp:0: > +# imagefolder="/mnt/vms/colo-test" > + > +# qemu-img create -f qcow2 $imagefolder/secondary-active.qcow2 10G > + > +# qemu-img create -f qcow2 $imagefolder/secondary-hidden.qcow2 10G > + > +# qemu-system-x86_64 -enable-kvm -cpu qemu64,+kvmclock -m 512 -smp > 1 -qmp stdio \ > + -vnc :1 -k de -device piix3-usb-uhci -device usb-tablet -name secondary \ > + -netdev tap,id=hn0,vhost=off,helper=/usr/lib/qemu/qemu-bridge-helper > \ > + -device rtl8139,id=e0,netdev=hn0 \ > + -chardev socket,id=red0,host=127.0.0.1,port=9003,reconnect=1 \ > + -chardev socket,id=red1,host=127.0.0.1,port=9004,reconnect=1 \ > + -object filter-redirector,id=f1,netdev=hn0,queue=tx,indev=red0 \ > + -object filter-redirector,id=f2,netdev=hn0,queue=rx,outdev=red1 \ > + -object filter-rewriter,id=rew0,netdev=hn0,queue=all \ > + -drive if=none,id=parent0,file.filename=$imagefolder/primary- > copy.qcow2,driver=qcow2 \ > + -drive > +if=none,id=childs0,driver=replication,mode=secondary,file.driver=qcow2, > +\ > +top-id=childs0,file.file.filename=$imagefolder/secondary-active.qcow2,\ >
Re: [Qemu-devel] [PATCH v2 3/3] Update Documentation
Subject "Update Documentation" is too vague, because (1) it lacks a subsystem prefix, and (2) it fails to hint at what it is updated for. Suggest something like "colo: Update documentation for FIXME", or maybe "docs/COLO-FT.txt: Update for FIXME", with a suitable replacement for FIXME.
