Re: [Qemu-devel] [PATCH v2 3/6] hw/mips_int: hold BQL for all interrupt requests

2018-04-04 Thread Paolo Bonzini
On 04/04/2018 15:44, Alex Bennée wrote: Signed-off-by: Miodrag Dinic Signed-off-by: Aleksandar Markovic >> Is this actually necessary? What paths are not taking the lock? > Helpers functions have to manually take the lock. AIUI

Re: [Qemu-devel] [PATCH v2 3/6] hw/mips_int: hold BQL for all interrupt requests

2018-04-04 Thread Alex Bennée
Paolo Bonzini writes: > On 04/04/2018 12:23, Alex Bennée wrote: >> >>> From: Aleksandar Markovic >>> >>> Make sure BQL is held for all interrupt requests. >>> >>> For MTTCG-enabled configurations, handling soft and hard interrupts >>> between

Re: [Qemu-devel] [PATCH v2 3/6] hw/mips_int: hold BQL for all interrupt requests

2018-04-04 Thread Paolo Bonzini
On 04/04/2018 12:23, Alex Bennée wrote: > >> From: Aleksandar Markovic >> >> Make sure BQL is held for all interrupt requests. >> >> For MTTCG-enabled configurations, handling soft and hard interrupts >> between vCPUs must be properly locked. By acquiring BQL, make

Re: [Qemu-devel] [PATCH v2 3/6] hw/mips_int: hold BQL for all interrupt requests

2018-04-04 Thread Alex Bennée
Aleksandar Markovic writes: > From: Aleksandar Markovic > > Make sure BQL is held for all interrupt requests. > > For MTTCG-enabled configurations, handling soft and hard interrupts > between vCPUs must be properly locked. By