Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/14/2018 01:39 PM, Kevin O'Connor wrote: On Tue, Feb 13, 2018 at 03:29:20PM -0500, Stefan Berger wrote: [...] In these 0x400 bytes we have 256 bytes that are used for configuration flags describing the supported opcode as you previously described. This array allows us to decouple the

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On Tue, Feb 13, 2018 at 03:29:20PM -0500, Stefan Berger wrote: [...] > In these 0x400 bytes we have 256 bytes that are used for configuration flags > describing the supported opcode as you previously described. This array > allows us to decouple the firmware implementation from the ACPI code and

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/13/2018 04:04 PM, Laszlo Ersek wrote: On 02/13/18 21:29, Stefan Berger wrote: On 02/13/2018 02:59 PM, Laszlo Ersek wrote: On 02/13/18 20:37, Kevin O'Connor wrote: On Tue, Feb 13, 2018 at 05:16:49PM +0100, Laszlo Ersek wrote: On 02/12/18 21:49, Stefan Berger wrote: On 02/12/2018 03:46

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/13/18 21:29, Stefan Berger wrote: > On 02/13/2018 02:59 PM, Laszlo Ersek wrote: >> On 02/13/18 20:37, Kevin O'Connor wrote: >>> On Tue, Feb 13, 2018 at 05:16:49PM +0100, Laszlo Ersek wrote: On 02/12/18 21:49, Stefan Berger wrote: > On 02/12/2018 03:46 PM, Kevin O'Connor wrote:

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/13/2018 02:59 PM, Laszlo Ersek wrote: On 02/13/18 20:37, Kevin O'Connor wrote: On Tue, Feb 13, 2018 at 05:16:49PM +0100, Laszlo Ersek wrote: On 02/12/18 21:49, Stefan Berger wrote: On 02/12/2018 03:46 PM, Kevin O'Connor wrote: I'm not sure I fully understand the goals of the PPI

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/13/18 20:37, Kevin O'Connor wrote: > On Tue, Feb 13, 2018 at 05:16:49PM +0100, Laszlo Ersek wrote: >> On 02/12/18 21:49, Stefan Berger wrote: >>> On 02/12/2018 03:46 PM, Kevin O'Connor wrote: I'm not sure I fully understand the goals of the PPI interface. Here's what I understand

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On Tue, Feb 13, 2018 at 05:16:49PM +0100, Laszlo Ersek wrote: > On 02/12/18 21:49, Stefan Berger wrote: > > On 02/12/2018 03:46 PM, Kevin O'Connor wrote: > >> I'm not sure I fully understand the goals of the PPI interface. > >> Here's what I understand so far: > >> > >> The TPM specs define some

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/13/18 17:34, Igor Mammedov wrote: > On Tue, 13 Feb 2018 17:16:49 +0100 > Laszlo Ersek wrote: > > [...] >> >> It's possible that I'll scream for additional hw enlightement under OVMF >> later; so I suggest designing in some kind of feature negotiation up-front. > We can

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/13/18 17:19, Igor Mammedov wrote: > On Tue, 13 Feb 2018 16:39:01 +0100 > Laszlo Ersek wrote: > >> On 02/13/18 15:17, Igor Mammedov wrote: >>> On Tue, 13 Feb 2018 14:31:41 +0100 >>> Laszlo Ersek wrote: >>> On 02/13/18 13:57, Igor Mammedov

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On Tue, 13 Feb 2018 17:16:49 +0100 Laszlo Ersek wrote: [...] > > It's possible that I'll scream for additional hw enlightement under OVMF > later; so I suggest designing in some kind of feature negotiation up-front. We can add an extra fwcfg file for that later, when/if it's

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On Tue, 13 Feb 2018 16:39:01 +0100 Laszlo Ersek wrote: > On 02/13/18 15:17, Igor Mammedov wrote: > > On Tue, 13 Feb 2018 14:31:41 +0100 > > Laszlo Ersek wrote: > > > >> On 02/13/18 13:57, Igor Mammedov wrote: > >>> On Mon, 12 Feb 2018 15:17:21 -0500 >

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/12/18 21:49, Stefan Berger wrote: > On 02/12/2018 03:46 PM, Kevin O'Connor wrote: >> On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote: >>> The PPI device in this patch series allocates 0x400 bytes. 0x200 >>> bytes are >>> used by the OperationRegion() in this patch series. The

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/13/18 15:17, Igor Mammedov wrote: > On Tue, 13 Feb 2018 14:31:41 +0100 > Laszlo Ersek wrote: > >> On 02/13/18 13:57, Igor Mammedov wrote: >>> On Mon, 12 Feb 2018 15:17:21 -0500 >>> Stefan Berger wrote: >>> On 02/12/2018 02:45 PM,

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On Tue, 13 Feb 2018 14:31:41 +0100 Laszlo Ersek wrote: > On 02/13/18 13:57, Igor Mammedov wrote: > > On Mon, 12 Feb 2018 15:17:21 -0500 > > Stefan Berger wrote: > > > >> On 02/12/2018 02:45 PM, Kevin O'Connor wrote: > >>> On Fri, Feb 09, 2018

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/13/18 13:57, Igor Mammedov wrote: > On Mon, 12 Feb 2018 15:17:21 -0500 > Stefan Berger wrote: > >> On 02/12/2018 02:45 PM, Kevin O'Connor wrote: >>> On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote: I have played around with this patch and

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On Mon, 12 Feb 2018 15:17:21 -0500 Stefan Berger wrote: > On 02/12/2018 02:45 PM, Kevin O'Connor wrote: > > On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote: > >> I have played around with this patch and some modifications to EDK2. Though > >> for EDK2

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On Mon, 12 Feb 2018 13:45:17 -0500 Stefan Berger wrote: > On 02/12/2018 12:52 PM, Igor Mammedov wrote: > > On Mon, 12 Feb 2018 11:44:16 -0500 > > Stefan Berger wrote: > > > >> On 02/12/2018 09:27 AM, Igor Mammedov wrote: > >>> On Fri,

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/12/2018 03:46 PM, Kevin O'Connor wrote: On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote: The PPI device in this patch series allocates 0x400 bytes. 0x200 bytes are used by the OperationRegion() in this patch series. The rest was thought of for future extensions. To allow

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote: > The PPI device in this patch series allocates 0x400 bytes. 0x200 bytes are > used by the OperationRegion() in this patch series. The rest was thought of > for future extensions. > > To allow both firmwares to use PPI, we would need

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/12/2018 02:45 PM, Kevin O'Connor wrote: On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote: I have played around with this patch and some modifications to EDK2. Though for EDK2 the question is whether to try to circumvent their current implementation that uses SMM or use SMM.

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote: > I have played around with this patch and some modifications to EDK2. Though > for EDK2 the question is whether to try to circumvent their current > implementation that uses SMM or use SMM. With this patch so far I circumvent > it,

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/12/2018 12:52 PM, Igor Mammedov wrote: On Mon, 12 Feb 2018 11:44:16 -0500 Stefan Berger wrote: On 02/12/2018 09:27 AM, Igor Mammedov wrote: On Fri, 9 Feb 2018 15:19:31 -0500 Stefan Berger wrote: On 01/16/2018 10:51 AM, Stefan

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On Mon, 12 Feb 2018 11:44:16 -0500 Stefan Berger wrote: > On 02/12/2018 09:27 AM, Igor Mammedov wrote: > > On Fri, 9 Feb 2018 15:19:31 -0500 > > Stefan Berger wrote: > > > >> On 01/16/2018 10:51 AM, Stefan Berger wrote: > >>> The TPM

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/12/2018 09:27 AM, Igor Mammedov wrote: On Fri, 9 Feb 2018 15:19:31 -0500 Stefan Berger wrote: On 01/16/2018 10:51 AM, Stefan Berger wrote: The TPM Physical Presence interface consists of an ACPI part, a shared memory part, and code in the firmware. Users can

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On Fri, 9 Feb 2018 15:19:31 -0500 Stefan Berger wrote: > On 01/16/2018 10:51 AM, Stefan Berger wrote: > > The TPM Physical Presence interface consists of an ACPI part, a shared > > memory part, and code in the firmware. Users can send messages to the > > firmware by

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 01/16/2018 10:51 AM, Stefan Berger wrote: The TPM Physical Presence interface consists of an ACPI part, a shared memory part, and code in the firmware. Users can send messages to the firmware by writing a code into the shared memory through invoking the ACPI code. When a reboot happens, the