Re: [Qemu-devel] [PATCH v2 5/7] blockdev: refactor block-dirty-bitmap-clear transaction

2018-04-20 Thread Vladimir Sementsov-Ogievskiy
20.04.2018 01:47, John Snow wrote: On 04/16/2018 07:44 AM, Vladimir Sementsov-Ogievskiy wrote: bdrv_clear_dirty_bitmap do not fail, so we can call it in transaction commit, avoiding any rollback. After this, bdrv_undo_clear_dirty_bitmap() becomes unused, so, drop it. I'm trying to remember

Re: [Qemu-devel] [PATCH v2 5/7] blockdev: refactor block-dirty-bitmap-clear transaction

2018-04-19 Thread John Snow
On 04/16/2018 07:44 AM, Vladimir Sementsov-Ogievskiy wrote: > bdrv_clear_dirty_bitmap do not fail, so we can call it in transaction > commit, avoiding any rollback. > > After this, bdrv_undo_clear_dirty_bitmap() becomes unused, so, drop it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH v2 5/7] blockdev: refactor block-dirty-bitmap-clear transaction

2018-04-19 Thread John Snow
On 04/16/2018 07:44 AM, Vladimir Sementsov-Ogievskiy wrote: > bdrv_clear_dirty_bitmap do not fail, so we can call it in transaction > commit, avoiding any rollback. > > After this, bdrv_undo_clear_dirty_bitmap() becomes unused, so, drop it. > I'm trying to remember why we ever bothered doing