Re: [Qemu-devel] [PATCH v3] qemu-io: fix EOF Ctrl-D handling in qemu-io readline code

[Eric Blake]

On 02/12/2018 12:48 PM, Daniel P. Berrangé wrote:

From: "Daniel P. Berrange" 

qemu-io puts the TTY into non-canonical mode, which means no EOF processing is
done and thus getchar() will never return the EOF constant. Instead we have to
query the TTY attributes to determine the configured EOF character (usually
Ctrl-D / 0x4), and then explicitly check for that value. This fixes the
regression that prevented Ctrl-D from triggering an exit of qemu-io that has
existed since readline was first added in

   commit 0cf17e181798063c3824c8200ba46f25f54faa1a
   Author: Stefan Hajnoczi 
   Date:   Thu Nov 14 11:54:17 2013 +0100

 qemu-io: use readline.c

It also ensures that a newline is printed when exiting, to complete the
line output by the "qemu-io> " prompt.

Signed-off-by: Daniel P. Berrange 
---


Reviewed-by: Eric Blake 

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH v3] qemu-io: fix EOF Ctrl-D handling in qemu-io readline code

[Kevin Wolf]

Am 12.02.2018 um 19:48 hat Daniel P. Berrangé geschrieben:
> From: "Daniel P. Berrange" 
> 
> qemu-io puts the TTY into non-canonical mode, which means no EOF processing is
> done and thus getchar() will never return the EOF constant. Instead we have to
> query the TTY attributes to determine the configured EOF character (usually
> Ctrl-D / 0x4), and then explicitly check for that value. This fixes the
> regression that prevented Ctrl-D from triggering an exit of qemu-io that has
> existed since readline was first added in
> 
>   commit 0cf17e181798063c3824c8200ba46f25f54faa1a
>   Author: Stefan Hajnoczi 
>   Date:   Thu Nov 14 11:54:17 2013 +0100
> 
> qemu-io: use readline.c
> 
> It also ensures that a newline is printed when exiting, to complete the
> line output by the "qemu-io> " prompt.
> 
> Signed-off-by: Daniel P. Berrange 

Thanks, applied to the block branch.

Kevin