Re: [Qemu-devel] [PATCH v3] tests/microbit-test: Check nRF51 UART functionality

2018-11-08 Thread Stefan Hajnoczi 
On Mon, Nov 05, 2018 at 05:54:25PM +, Peter Maydell wrote:
> On 5 November 2018 at 10:45, Julia Suvorova  wrote:
> > Some functional tests for:
> > Basic reception/transmittion
> > Suspending
> > INTEN* registers
> >
> > Based-on: <20181031002526.14262-1-cont...@steffen-goertz.de>
> > Signed-off-by: Julia Suvorova 
> > ---
> > This patch was part of nRF51 UART patchset, but wasn't included in the 
> > latest
> > revision. Due to upcoming loader fixes, we need this test instead of
> > boot-serial-test, which doesn't support -device loader.
> >
> > v3:
> > * Fix directory leak [Stefan]
> >
> >  tests/microbit-test.c | 109 +-
> >  1 file changed, 107 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/microbit-test.c b/tests/microbit-test.c
> > index ab319eb466..23d343cfdd 100644
> > --- a/tests/microbit-test.c
> > +++ b/tests/microbit-test.c
> > @@ -21,9 +21,87 @@
> >  #include "hw/arm/nrf51.h"
> >  #include "hw/nvram/nrf51_nvm.h"
> >  #include "hw/gpio/nrf51_gpio.h"
> > +#include "hw/char/nrf51_uart.h"
> > +
> > +#include 
> > +#include 
> >
> >  #define FLASH_SIZE  (256 * NRF51_PAGE_SIZE)
> >
> > +static bool wait_for_event(uint32_t event_addr)
> > +{
> > +int i;
> > +
> > +for (i = 0; i < 1000; i++) {
> > +if (readl(event_addr) == 1) {
> > +writel(event_addr, 0x00);
> > +return true;
> > +}
> > +g_usleep(1);
> 
> Hmm, is this the right way to wait for a device model?
> I thought there was a qtest thing to say "advance the
> time in the QEMU under test" and otherwise its internal
> clock won't tick.

This function is used to wait for QEMU device emulation to report events
triggered by external I/O (the UNIX domain socket).  I think vm_clock is
unrelated to this.

We could rely on the fact that qtest runs in the main loop where the
UNIX domain socket is also processed.  In other words, it shouldn't take
more than a small constant N of event loop iterations (i.e. qtest
commands) before the UNIX domain socket has been processed and the UART
updates its event registers.  g_usleep() seems nicer than making that
assumption though...


signature.asc
Description: PGP signature

Re: [Qemu-devel] [PATCH v3] tests/microbit-test: Check nRF51 UART functionality

2018-11-08 Thread Stefan Hajnoczi 
On Mon, Nov 05, 2018 at 01:45:24PM +0300, Julia Suvorova wrote:
> +writel(NRF51_UART_BASE + A_UART_SUSPEND, 0x01);
> +writel(NRF51_UART_BASE + A_UART_TXD, 'h');
> +writel(NRF51_UART_BASE + A_UART_STARTTX, 0x01);
> +w_to_txd("world");
> +g_assert(read(sock_fd, s, 10) == 5);
> +g_assert(strcmp(s, "world") == 0);

Please use memcmp(3) instead.  A broken QEMU could send non-NUL
terminated data and strcmp(3) would go beyond the end of s[].

(I haven't looked back to see if s[6..9] was previously initialized to
'\0' but it's cleaner if the code makes it obvious that there is no bug
here.)


signature.asc
Description: PGP signature

Re: [Qemu-devel] [PATCH v3] tests/microbit-test: Check nRF51 UART functionality

2018-11-05 Thread Peter Maydell 
On 5 November 2018 at 10:45, Julia Suvorova  wrote:
> Some functional tests for:
> Basic reception/transmittion
> Suspending
> INTEN* registers
>
> Based-on: <20181031002526.14262-1-cont...@steffen-goertz.de>
> Signed-off-by: Julia Suvorova 
> ---
> This patch was part of nRF51 UART patchset, but wasn't included in the latest
> revision. Due to upcoming loader fixes, we need this test instead of
> boot-serial-test, which doesn't support -device loader.
>
> v3:
> * Fix directory leak [Stefan]
>
>  tests/microbit-test.c | 109 +-
>  1 file changed, 107 insertions(+), 2 deletions(-)
>
> diff --git a/tests/microbit-test.c b/tests/microbit-test.c
> index ab319eb466..23d343cfdd 100644
> --- a/tests/microbit-test.c
> +++ b/tests/microbit-test.c
> @@ -21,9 +21,87 @@
>  #include "hw/arm/nrf51.h"
>  #include "hw/nvram/nrf51_nvm.h"
>  #include "hw/gpio/nrf51_gpio.h"
> +#include "hw/char/nrf51_uart.h"
> +
> +#include 
> +#include 
>
>  #define FLASH_SIZE  (256 * NRF51_PAGE_SIZE)
>
> +static bool wait_for_event(uint32_t event_addr)
> +{
> +int i;
> +
> +for (i = 0; i < 1000; i++) {
> +if (readl(event_addr) == 1) {
> +writel(event_addr, 0x00);
> +return true;
> +}
> +g_usleep(1);

Hmm, is this the right way to wait for a device model?
I thought there was a qtest thing to say "advance the
time in the QEMU under test" and otherwise its internal
clock won't tick.

> +}
> +
> +return false;
> +}

>  int main(int argc, char **argv)
>  {
> -int ret;
> +int ret, sock_fd;
> +char serialtmpdir[] = "/tmp/qtest-microbit-serial-sXX";
> +char serialtmp[40];
> +struct sockaddr_un addr;
> +
> +g_assert(mkdtemp(serialtmpdir));
> +sprintf(serialtmp, "%s/sock", serialtmpdir);

Prefer g_strdup_printf() to sprintf into a fixed size buffer:
it allocates memory so we don't have to think about whether
the buffer might ever overflow or whether we miscounted a
buffer length.

> +
> +sock_fd = socket(AF_UNIX, SOCK_STREAM, 0);
> +g_assert(sock_fd != -1);
> +
> +memset(, 0, sizeof(struct sockaddr_un));
> +
> +addr.sun_family = AF_UNIX;
> +strncpy(addr.sun_path, serialtmp, sizeof(addr.sun_path) - 1);
>
>  g_test_init(, , NULL);
>
> -global_qtest = qtest_initf("-machine microbit");
> +global_qtest = qtest_initf("-machine microbit "
> +   "-chardev socket,id=s0,path=%s,server,nowait "
> +   "-no-shutdown -serial chardev:s0",
> +   serialtmp);
> +
> +g_assert(connect(sock_fd, (const struct sockaddr *) ,
> + sizeof(struct sockaddr_un)) != -1);
>
> +unlink(serialtmp);
> +rmdir(serialtmpdir);

"Create a socket so I can give one end of it to a QEMU
chardev and use the other end in my test code" seems
like a feature that would be more widely useful than in
just this test, but I'll let people who understand our
qtest framework better than me weigh in on that.

thanks
-- PMM

Re: [Qemu-devel] [PATCH v3] tests/microbit-test: Check nRF51 UART functionality

2018-11-05 Thread Julia Suvorova via Qemu-devel 

On 05.11.2018 19:16, Philippe Mathieu-Daudé wrote:

Hi Julia,

On 5/11/18 11:45, Julia Suvorova via Qemu-devel wrote:

Some functional tests for:
 Basic reception/transmittion
 Suspending
 INTEN* registers

Based-on: <20181031002526.14262-1-cont...@steffen-goertz.de>
Signed-off-by: Julia Suvorova 
---


Lines below '---' are not included in the git history.

The Based-on: tag is temporary and not relevant to the history, you should insert it here, so it will be automatically 
dropped once your patch get applied.


Seems reasonable. I'll do it in the next revision, since I have to
rebase it anyway as soon as Steffen patches will be merged.
BTW, you can find a couple of Based-on in git history :)

Best regards, Julia Suvorova.

Re: [Qemu-devel] [PATCH v3] tests/microbit-test: Check nRF51 UART functionality

2018-11-05 Thread Philippe Mathieu-Daudé 

Hi Julia,

On 5/11/18 11:45, Julia Suvorova via Qemu-devel wrote:

Some functional tests for:
 Basic reception/transmittion
 Suspending
 INTEN* registers

Based-on: <20181031002526.14262-1-cont...@steffen-goertz.de>
Signed-off-by: Julia Suvorova 
---


Lines below '---' are not included in the git history.

The Based-on: tag is temporary and not relevant to the history, you 
should insert it here, so it will be automatically dropped once your 
patch get applied.


Regards,

Phil.


This patch was part of nRF51 UART patchset, but wasn't included in the latest
revision. Due to upcoming loader fixes, we need this test instead of
boot-serial-test, which doesn't support -device loader.

v3:
 * Fix directory leak [Stefan]

  tests/microbit-test.c | 109 +-
  1 file changed, 107 insertions(+), 2 deletions(-)

diff --git a/tests/microbit-test.c b/tests/microbit-test.c
index ab319eb466..23d343cfdd 100644
--- a/tests/microbit-test.c
+++ b/tests/microbit-test.c
@@ -21,9 +21,87 @@
  #include "hw/arm/nrf51.h"
  #include "hw/nvram/nrf51_nvm.h"
  #include "hw/gpio/nrf51_gpio.h"
+#include "hw/char/nrf51_uart.h"
+
+#include 
+#include 
  
  #define FLASH_SIZE  (256 * NRF51_PAGE_SIZE)
  
+static bool wait_for_event(uint32_t event_addr)

+{
+int i;
+
+for (i = 0; i < 1000; i++) {
+if (readl(event_addr) == 1) {
+writel(event_addr, 0x00);
+return true;
+}
+g_usleep(1);
+}
+
+return false;
+}
+
+static void rw_to_rxd(int sock_fd, const char *in, char *out)
+{
+int i;
+
+g_assert(write(sock_fd, in, strlen(in)) == strlen(in));
+for (i = 0; i < strlen(in); i++) {
+g_assert(wait_for_event(NRF51_UART_BASE + A_UART_RXDRDY));
+out[i] = readl(NRF51_UART_BASE + A_UART_RXD);
+}
+out[i] = '\0';
+}
+
+static void w_to_txd(const char *in)
+{
+int i;
+
+for (i = 0; i < strlen(in); i++) {
+writel(NRF51_UART_BASE + A_UART_TXD, in[i]);
+g_assert(wait_for_event(NRF51_UART_BASE + A_UART_TXDRDY));
+}
+}
+
+static void test_nrf51_uart(const void *data)
+{
+int sock_fd = *((const int *) data);
+char s[10];
+
+g_assert(write(sock_fd, "c", 1) == 1);
+g_assert(readl(NRF51_UART_BASE + A_UART_RXD) == 0);
+
+writel(NRF51_UART_BASE + A_UART_ENABLE, 0x04);
+writel(NRF51_UART_BASE + A_UART_STARTRX, 0x01);
+
+g_assert(wait_for_event(NRF51_UART_BASE + A_UART_RXDRDY));
+writel(NRF51_UART_BASE + A_UART_RXDRDY, 0x00);
+g_assert(readl(NRF51_UART_BASE + A_UART_RXD) == 'c');
+
+writel(NRF51_UART_BASE + A_UART_INTENSET, 0x04);
+g_assert(readl(NRF51_UART_BASE + A_UART_INTEN) == 0x04);
+writel(NRF51_UART_BASE + A_UART_INTENCLR, 0x04);
+g_assert(readl(NRF51_UART_BASE + A_UART_INTEN) == 0x00);
+
+rw_to_rxd(sock_fd, "hello", s);
+g_assert(strcmp(s, "hello") == 0);
+
+writel(NRF51_UART_BASE + A_UART_STARTTX, 0x01);
+w_to_txd("d");
+g_assert(read(sock_fd, s, 10) == 1);
+g_assert(s[0] == 'd');
+
+writel(NRF51_UART_BASE + A_UART_SUSPEND, 0x01);
+writel(NRF51_UART_BASE + A_UART_TXD, 'h');
+writel(NRF51_UART_BASE + A_UART_STARTTX, 0x01);
+w_to_txd("world");
+g_assert(read(sock_fd, s, 10) == 5);
+g_assert(strcmp(s, "world") == 0);
+}
+
+
  static void fill_and_erase(hwaddr base, hwaddr size, uint32_t address_reg)
  {
  /* Fill memory */
@@ -223,17 +301,44 @@ static void test_nrf51_gpio(void)
  
  int main(int argc, char **argv)

  {
-int ret;
+int ret, sock_fd;
+char serialtmpdir[] = "/tmp/qtest-microbit-serial-sXX";
+char serialtmp[40];
+struct sockaddr_un addr;
+
+g_assert(mkdtemp(serialtmpdir));
+sprintf(serialtmp, "%s/sock", serialtmpdir);
+
+sock_fd = socket(AF_UNIX, SOCK_STREAM, 0);
+g_assert(sock_fd != -1);
+
+memset(, 0, sizeof(struct sockaddr_un));
+
+addr.sun_family = AF_UNIX;
+strncpy(addr.sun_path, serialtmp, sizeof(addr.sun_path) - 1);
  
  g_test_init(, , NULL);
  
-global_qtest = qtest_initf("-machine microbit");

+global_qtest = qtest_initf("-machine microbit "
+   "-chardev socket,id=s0,path=%s,server,nowait "
+   "-no-shutdown -serial chardev:s0",
+   serialtmp);
+
+g_assert(connect(sock_fd, (const struct sockaddr *) ,
+ sizeof(struct sockaddr_un)) != -1);
  
+unlink(serialtmp);

+rmdir(serialtmpdir);
+
+qtest_add_data_func("/microbit/nrf51/uart", _fd, test_nrf51_uart);
  qtest_add_func("/microbit/nrf51/nvmc", test_nrf51_nvmc);
  qtest_add_func("/microbit/nrf51/gpio", test_nrf51_gpio);
  
  ret = g_test_run();
  
  qtest_quit(global_qtest);

+
+close(sock_fd);
+
  return ret;
  }

Re: [Qemu-devel] [PATCH v3] tests/microbit-test: Check nRF51 UART functionality

2018-11-05 Thread no-reply 
Hi,

This series failed docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

Type: series
Message-id: 20181105104524.933-1-jus...@mail.ru
Subject: [Qemu-devel] [PATCH v3] tests/microbit-test: Check nRF51 UART 
functionality

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-quick@centos7 SHOW_ENV=1 J=8
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
dba9632258 tests/microbit-test: Check nRF51 UART functionality

=== OUTPUT BEGIN ===
  BUILD   centos7
make[1]: Entering directory '/var/tmp/patchew-tester-tmp-433peg19/src'
  GEN 
/var/tmp/patchew-tester-tmp-433peg19/src/docker-src.2018-11-05-10.29.47.1554/qemu.tar
Cloning into 
'/var/tmp/patchew-tester-tmp-433peg19/src/docker-src.2018-11-05-10.29.47.1554/qemu.tar.vroot'...
done.
Your branch is up-to-date with 'origin/test'.
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into 
'/var/tmp/patchew-tester-tmp-433peg19/src/docker-src.2018-11-05-10.29.47.1554/qemu.tar.vroot/dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered 
for path 'ui/keycodemapdb'
Cloning into 
'/var/tmp/patchew-tester-tmp-433peg19/src/docker-src.2018-11-05-10.29.47.1554/qemu.tar.vroot/ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out 
'6b3d716e2b6472eb7189d3220552280ef3d832ce'
  COPYRUNNER
RUN test-quick in qemu:centos7 
Packages installed:
SDL-devel-1.2.15-14.el7.x86_64
bison-3.0.4-1.el7.x86_64
bzip2-1.0.6-13.el7.x86_64
bzip2-devel-1.0.6-13.el7.x86_64
ccache-3.3.4-1.el7.x86_64
csnappy-devel-0-6.20150729gitd7bc683.el7.x86_64
flex-2.5.37-3.el7.x86_64
gcc-4.8.5-28.el7_5.1.x86_64
gettext-0.19.8.1-2.el7.x86_64
git-1.8.3.1-14.el7_5.x86_64
glib2-devel-2.54.2-2.el7.x86_64
libaio-devel-0.3.109-13.el7.x86_64
libepoxy-devel-1.3.1-2.el7_5.x86_64
libfdt-devel-1.4.6-1.el7.x86_64
lzo-devel-2.06-8.el7.x86_64
make-3.82-23.el7.x86_64
mesa-libEGL-devel-17.2.3-8.20171019.el7.x86_64
mesa-libgbm-devel-17.2.3-8.20171019.el7.x86_64
nettle-devel-2.7.1-8.el7.x86_64
package g++ is not installed
package librdmacm-devel is not installed
pixman-devel-0.34.0-1.el7.x86_64
spice-glib-devel-0.34-3.el7_5.1.x86_64
spice-server-devel-0.14.0-2.el7_5.4.x86_64
tar-1.26-34.el7.x86_64
vte-devel-0.28.2-10.el7.x86_64
xen-devel-4.6.6-12.el7.x86_64
zlib-devel-1.2.7-17.el7.x86_64

Environment variables:
PACKAGES=bison bzip2 bzip2-devel ccache csnappy-devel flex  
   g++ gcc gettext git glib2-devel libaio-devel 
libepoxy-devel libfdt-devel librdmacm-devel lzo-devel make 
mesa-libEGL-devel mesa-libgbm-devel nettle-devel pixman-devel 
SDL-devel spice-glib-devel spice-server-devel tar vte-devel 
xen-devel zlib-devel
HOSTNAME=240c1c2c4ec9
MAKEFLAGS= -j8
J=8
CCACHE_DIR=/var/tmp/ccache
EXTRA_CONFIGURE_OPTS=
V=
SHOW_ENV=1
PATH=/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
PWD=/
TARGET_LIST=
SHLVL=1
HOME=/home/patchew
TEST_DIR=/tmp/qemu-test
FEATURES= dtc
DEBUG=
_=/usr/bin/env

Configure options:
--enable-werror --target-list=x86_64-softmmu,aarch64-softmmu 
--prefix=/tmp/qemu-test/install
No C++ compiler available; disabling C++ specific optional code
Install prefix/tmp/qemu-test/install
BIOS directory/tmp/qemu-test/install/share/qemu
firmware path /tmp/qemu-test/install/share/qemu-firmware
binary directory  /tmp/qemu-test/install/bin
library directory /tmp/qemu-test/install/lib
module directory  /tmp/qemu-test/install/lib/qemu
libexec directory /tmp/qemu-test/install/libexec
include directory /tmp/qemu-test/install/include
config directory  /tmp/qemu-test/install/etc
local state directory   /tmp/qemu-test/install/var
Manual directory  /tmp/qemu-test/install/share/man
ELF interp prefix /usr/gnemul/qemu-%M
Source path   /tmp/qemu-test/src
GIT binarygit
GIT submodules
C compilercc
Host C compiler   cc
C++ compiler  
Objective-C compiler cc
ARFLAGS   rv
CFLAGS-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g 
QEMU_CFLAGS   -I/usr/include/pixman-1-Werror -pthread 
-I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -fPIE -DPIE -m64 -mcx16 
-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes 
-Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes 
-fno-strict-aliasing -fno-common -fwrapv  -Wendif-labels 
-Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security 
-Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration 
-Wold-style-definition -Wtype-limits -fstack-protector-strong 
-Wno-missing-braces   -I/usr/include/libpng15 -pthread 
-I/usr/include/spice-server -I/usr/include/cacard -I/usr/include/glib-2.0

Re: [Qemu-devel] [PATCH v3] tests/microbit-test: Check nRF51 UART functionality

2018-11-05 Thread no-reply 
Hi,

This series failed docker-mingw@fedora build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

Type: series
Message-id: 20181105104524.933-1-jus...@mail.ru
Subject: [Qemu-devel] [PATCH v3] tests/microbit-test: Check nRF51 UART 
functionality

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=8
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]
patchew/20181016093703.10637-1-peter.mayd...@linaro.org -> 
patchew/20181016093703.10637-1-peter.mayd...@linaro.org
 * [new tag]   patchew/20181105150806.13649-1-jcfara...@gmail.com 
-> patchew/20181105150806.13649-1-jcfara...@gmail.com
 * [new tag]   
patchew/20181105151132.13884-1-peter.mayd...@linaro.org -> 
patchew/20181105151132.13884-1-peter.mayd...@linaro.org
Switched to a new branch 'test'
dba9632258 tests/microbit-test: Check nRF51 UART functionality

=== OUTPUT BEGIN ===
  BUILD   fedora
make[1]: Entering directory '/var/tmp/patchew-tester-tmp-ceo1a87s/src'
  GEN 
/var/tmp/patchew-tester-tmp-ceo1a87s/src/docker-src.2018-11-05-10.28.42.890/qemu.tar
Cloning into 
'/var/tmp/patchew-tester-tmp-ceo1a87s/src/docker-src.2018-11-05-10.28.42.890/qemu.tar.vroot'...
done.
Checking out files:  45% (2913/6455)   
Checking out files:  46% (2970/6455)   
Checking out files:  47% (3034/6455)   
Checking out files:  48% (3099/6455)   
Checking out files:  49% (3163/6455)   
Checking out files:  50% (3228/6455)   
Checking out files:  51% (3293/6455)   
Checking out files:  52% (3357/6455)   
Checking out files:  53% (3422/6455)   
Checking out files:  54% (3486/6455)   
Checking out files:  55% (3551/6455)   
Checking out files:  56% (3615/6455)   
Checking out files:  57% (3680/6455)   
Checking out files:  58% (3744/6455)   
Checking out files:  59% (3809/6455)   
Checking out files:  60% (3873/6455)   
Checking out files:  61% (3938/6455)   
Checking out files:  62% (4003/6455)   
Checking out files:  63% (4067/6455)   
Checking out files:  64% (4132/6455)   
Checking out files:  65% (4196/6455)   
Checking out files:  66% (4261/6455)   
Checking out files:  67% (4325/6455)   
Checking out files:  68% (4390/6455)   
Checking out files:  69% (4454/6455)   
Checking out files:  70% (4519/6455)   
Checking out files:  71% (4584/6455)   
Checking out files:  72% (4648/6455)   
Checking out files:  73% (4713/6455)   
Checking out files:  74% (4777/6455)   
Checking out files:  75% (4842/6455)   
Checking out files:  76% (4906/6455)   
Checking out files:  77% (4971/6455)   
Checking out files:  78% (5035/6455)   
Checking out files:  79% (5100/6455)   
Checking out files:  80% (5164/6455)   
Checking out files:  81% (5229/6455)   
Checking out files:  82% (5294/6455)   
Checking out files:  83% (5358/6455)   
Checking out files:  84% (5423/6455)   
Checking out files:  85% (5487/6455)   
Checking out files:  86% (5552/6455)   
Checking out files:  87% (5616/6455)   
Checking out files:  88% (5681/6455)   
Checking out files:  89% (5745/6455)   
Checking out files:  90% (5810/6455)   
Checking out files:  91% (5875/6455)   
Checking out files:  92% (5939/6455)   
Checking out files:  93% (6004/6455)   
Checking out files:  94% (6068/6455)   
Checking out files:  95% (6133/6455)   
Checking out files:  96% (6197/6455)   
Checking out files:  97% (6262/6455)   
Checking out files:  98% (6326/6455)   
Checking out files:  99% (6391/6455)   
Checking out files: 100% (6455/6455)   
Checking out files: 100% (6455/6455), done.
Your branch is up-to-date with 'origin/test'.
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into 
'/var/tmp/patchew-tester-tmp-ceo1a87s/src/docker-src.2018-11-05-10.28.42.890/qemu.tar.vroot/dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered 
for path 'ui/keycodemapdb'
Cloning into 
'/var/tmp/patchew-tester-tmp-ceo1a87s/src/docker-src.2018-11-05-10.28.42.890/qemu.tar.vroot/ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out 
'6b3d716e2b6472eb7189d3220552280ef3d832ce'
  COPYRUNNER
RUN test-mingw in qemu:fedora 
Packages installed:
SDL2-devel-2.0.8-5.fc28.x86_64
bc-1.07.1-5.fc28.x86_64
bison-3.0.4-9.fc28.x86_64
bluez-libs-devel-5.50-1.fc28.x86_64
brlapi-devel-0.6.7-19.fc28.x86_64
bzip2-1.0.6-26.fc28.x86_64
bzip2-devel-1.0.6-26.fc28.x86_64
ccache-3.4.2-2.fc28.x86_64
clang-6.0.1-1.fc28.x86_64
device-mapper-multipath-devel-0.7.4-3.git07e7bd5.fc28.x86_64
findutils-4.6.0-19.fc28.x86_64
flex-2.6.1-7.fc28.x86_64
gcc-8.1.1-5.fc28.x86_64
gcc-c++-8.1.1-5.fc28.x86_64
gettext-0.19.8.1-14.fc28.x86_64
git-2.17.1-3.fc28.x86_64
glib2-devel-2.56.1-4.fc28.x86_64
glusterfs-api-devel-4.1.2-2.fc28.x86_64
gnutls-devel-3.6.3-3.fc28.x86_64

Re: [Qemu-devel] [PATCH v3] tests/microbit-test: Check nRF51 UART functionality

2018-11-05 Thread Julia Suvorova via Qemu-devel 

On 05.11.2018 15:24, Alex Bennée wrote:


Julia Suvorova via Qemu-devel  writes:


Some functional tests for:
 Basic reception/transmittion
 Suspending
 INTEN* registers

Based-on: <20181031002526.14262-1-cont...@steffen-goertz.de>
Signed-off-by: Julia Suvorova 
---
This patch was part of nRF51 UART patchset, but wasn't included in the latest
revision. Due to upcoming loader fixes, we need this test instead of
boot-serial-test, which doesn't support -device loader.


This didn't apply cleanly to master as the test isn't there yet. But the
uart patches look partially merged. Can I have a reference for the
series or tree please?


The patch is based on this patchset (patches 7 & 10):
https://lists.nongnu.org/archive/html/qemu-devel/2018-10/msg06718.html
Uart patchset was fully merged except this patch.

Best regards, Julia Suvorova.

Re: [Qemu-devel] [PATCH v3] tests/microbit-test: Check nRF51 UART functionality

2018-11-05 Thread Alex Bennée 


Julia Suvorova via Qemu-devel  writes:

> Some functional tests for:
> Basic reception/transmittion
> Suspending
> INTEN* registers
>
> Based-on: <20181031002526.14262-1-cont...@steffen-goertz.de>
> Signed-off-by: Julia Suvorova 
> ---
> This patch was part of nRF51 UART patchset, but wasn't included in the latest
> revision. Due to upcoming loader fixes, we need this test instead of
> boot-serial-test, which doesn't support -device loader.

This didn't apply cleanly to master as the test isn't there yet. But the
uart patches look partially merged. Can I have a reference for the
series or tree please?

--
Alex Bennée