Re: [Qemu-devel] [PATCH v3-a 26/27] target/arm: Extend vec_reg_offset to larger sizes

2018-05-17 Thread Peter Maydell
On 17 May 2018 at 17:51, Richard Henderson wrote: > On 05/17/2018 08:57 AM, Peter Maydell wrote: >> This looks right for element sizes up to 8, but I don't understand >> how it handles 16 byte elements as the commit message says -- the >> d[0] and d[1] are the wrong way round and don't form a sing

Re: [Qemu-devel] [PATCH v3-a 26/27] target/arm: Extend vec_reg_offset to larger sizes

2018-05-17 Thread Richard Henderson
On 05/17/2018 08:57 AM, Peter Maydell wrote: > This looks right for element sizes up to 8, but I don't understand > how it handles 16 byte elements as the commit message says -- the > d[0] and d[1] are the wrong way round and don't form a single > 16-byte big-endian value, so they must need special

Re: [Qemu-devel] [PATCH v3-a 26/27] target/arm: Extend vec_reg_offset to larger sizes

2018-05-17 Thread Peter Maydell
On 16 May 2018 at 23:30, Richard Henderson wrote: > Rearrange the arithmetic so that we are agnostic about the total size > of the vector and the size of the element. This will allow us to index > up to the 32nd byte and with 16-byte elements. > > Signed-off-by: Richard Henderson > --- > target