On Mon, Sep 19, 2016 at 07:00:26PM +0200, Lluís Vilanova wrote:
> Daniel P Berrange writes:
>
> > The trace_event_count, trace_event_id and
> > trace_event_pattern methods are no longer required
> > now that everything is using the iterator APIs
>
> > The trace_event_set_state and trace_event_set_vcpu_state
> > macros were also unused.
>
> Wouldn't it make more sense to fold the removal of trace_event_pattern() into
> the previous patch?
No - that would be mixing two changes in one commit. There are two
logically separate changes here - one is changing an internal
implementation detail, and one is altering the public API to remove
methods.
Regards,
Daniel
--
|: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
