Re: [Qemu-devel] [PATCH v3 1/3] exec: split cpu_exec_init()

2016-10-17 Thread Eduardo Habkost
On Sat, Oct 15, 2016 at 12:52:47AM +0200, Laurent Vivier wrote: > Put in cpu_exec_initfn() what initializes the CPU, > and let in cpu_exec_init() what adds it to the environment. > > As cpu_exec_initfn() is called by all XX_cpu_initfn() call it > directly in cpu_common_initfn(). > cpu_exec_init()

Re: [Qemu-devel] [PATCH v3 1/3] exec: split cpu_exec_init()

2016-10-17 Thread Igor Mammedov
On Sat, 15 Oct 2016 00:52:47 +0200 Laurent Vivier wrote: > Put in cpu_exec_initfn() what initializes the CPU, > and let in cpu_exec_init() what adds it to the environment. s/let/leave/ > > As cpu_exec_initfn() is called by all XX_cpu_initfn() maybe add comma before "call it" > call it > directly

Re: [Qemu-devel] [PATCH v3 1/3] exec: split cpu_exec_init()

2016-10-16 Thread David Gibson
On Sat, Oct 15, 2016 at 12:52:47AM +0200, Laurent Vivier wrote: > Put in cpu_exec_initfn() what initializes the CPU, > and let in cpu_exec_init() what adds it to the environment. > > As cpu_exec_initfn() is called by all XX_cpu_initfn() call it > directly in cpu_common_initfn(). > cpu_exec_init()