Re: [Qemu-devel] [PATCH v3 10/13] nvdimm: convert nvdimm_mr into a pointer

2018-06-18 Thread Igor Mammedov
On Fri, 15 Jun 2018 16:04:45 +0200 David Hildenbrand wrote: > This way we can easily check if the region has already been inititalized > without having to rely on the size of an uninitialized region being 0. > > Signed-off-by: David Hildenbrand Reviewed-by: Igor Mammedov > --- >

Re: [Qemu-devel] [PATCH v3 10/13] nvdimm: convert nvdimm_mr into a pointer

2018-06-18 Thread David Hildenbrand
On 18.06.2018 02:49, David Gibson wrote: > On Fri, Jun 15, 2018 at 04:04:45PM +0200, David Hildenbrand wrote: >> This way we can easily check if the region has already been inititalized >> without having to rely on the size of an uninitialized region being 0. >> >> Signed-off-by: David Hildenbrand

Re: [Qemu-devel] [PATCH v3 10/13] nvdimm: convert nvdimm_mr into a pointer

2018-06-17 Thread David Gibson
On Fri, Jun 15, 2018 at 04:04:45PM +0200, David Hildenbrand wrote: > This way we can easily check if the region has already been inititalized > without having to rely on the size of an uninitialized region being 0. > > Signed-off-by: David Hildenbrand I'm not terribly convinced that this is a