Re: [Qemu-devel] [PATCH v3 2/2] s390x: Change return type of virtio_ccw_exit to void.
On Tue, 6 Mar 2018 23:40:18 + neewrote: > On Tue, Mar 6, 2018 at 2:40 PM, Cornelia Huck wrote: > > On Tue, 6 Mar 2018 10:07:21 + > > Nia Alarie wrote: > > > >> Allows a branch to be removed - this function always returns 0. > >> > >> Signed-off-by: Nia Alarie > >> Reviewed-by: Christian Borntraeger > >> --- > >> hw/s390x/virtio-ccw.c | 6 +++--- > >> hw/s390x/virtio-ccw.h | 2 +- > >> 2 files changed, 4 insertions(+), 4 deletions(-) > > > > While your patch is not wrong, I'd prefer to skip changing the exit > > functions and convert virtio-ccw to unrealize instead. > > > > Should not be too hard; do you want to take a stab at it? > > Is there any difference in semantics between exit and unrealize aside > from the arguments and return type? In our case, it should be a simple transformation to the new functions.
Re: [Qemu-devel] [PATCH v3 2/2] s390x: Change return type of virtio_ccw_exit to void.
On Tue, Mar 6, 2018 at 2:40 PM, Cornelia Huckwrote: > On Tue, 6 Mar 2018 10:07:21 + > Nia Alarie wrote: > >> Allows a branch to be removed - this function always returns 0. >> >> Signed-off-by: Nia Alarie >> Reviewed-by: Christian Borntraeger >> --- >> hw/s390x/virtio-ccw.c | 6 +++--- >> hw/s390x/virtio-ccw.h | 2 +- >> 2 files changed, 4 insertions(+), 4 deletions(-) > > While your patch is not wrong, I'd prefer to skip changing the exit > functions and convert virtio-ccw to unrealize instead. > > Should not be too hard; do you want to take a stab at it? Is there any difference in semantics between exit and unrealize aside from the arguments and return type?
Re: [Qemu-devel] [PATCH v3 2/2] s390x: Change return type of virtio_ccw_exit to void.
On Tue, 6 Mar 2018 10:07:21 + Nia Alariewrote: > Allows a branch to be removed - this function always returns 0. > > Signed-off-by: Nia Alarie > Reviewed-by: Christian Borntraeger > --- > hw/s390x/virtio-ccw.c | 6 +++--- > hw/s390x/virtio-ccw.h | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) While your patch is not wrong, I'd prefer to skip changing the exit functions and convert virtio-ccw to unrealize instead. Should not be too hard; do you want to take a stab at it?