Re: [Qemu-devel] [PATCH v3 29/32] ahci: properly shadow the TFD register

2014-08-14 Thread John Snow
On 08/14/2014 12:09 PM, Stefan Hajnoczi wrote: On Wed, Aug 13, 2014 at 05:56:12PM -0400, John Snow wrote: @@ -497,6 +495,8 @@ static void ahci_reset_port(AHCIState *s, int port) pr-scr_stat = 0; pr-scr_err = 0; pr-scr_act = 0; +pr-tfdata = 0x7F; Is it possible to avoid

Re: [Qemu-devel] [PATCH v3 29/32] ahci: properly shadow the TFD register

2014-08-14 Thread Stefan Hajnoczi
On Wed, Aug 13, 2014 at 05:56:12PM -0400, John Snow wrote: @@ -497,6 +495,8 @@ static void ahci_reset_port(AHCIState *s, int port) pr-scr_stat = 0; pr-scr_err = 0; pr-scr_act = 0; +pr-tfdata = 0x7F; Is it possible to avoid the magic number? pgpmIgF53vtBL.pgp Description:

Re: [Qemu-devel] [PATCH v3 29/32] ahci: properly shadow the TFD register

2014-08-14 Thread Stefan Hajnoczi
On Thu, Aug 14, 2014 at 12:13:51PM -0400, John Snow wrote: On 08/14/2014 12:09 PM, Stefan Hajnoczi wrote: On Wed, Aug 13, 2014 at 05:56:12PM -0400, John Snow wrote: @@ -497,6 +495,8 @@ static void ahci_reset_port(AHCIState *s, int port) pr-scr_stat = 0; pr-scr_err = 0;