On Mon, 09 Apr 2018 12:15:10 +0200 Greg Kurz <gr...@kaod.org> wrote: > A recent patch fixed leaks of the dynamically allocated vcdev->vdev.name > field in vfio_ccw_realize(), but we now have three freeing sites for it. > This is unfortunate and seems to indicate something is wrong with its > life cycle. > > The root issue is that vcdev->vdev.name is set before vfio_get_device() > is called, which theoretically prevents to call vfio_put_device() to > do the freeing. Well actually, we could call it anyway because > vfio_put_base_device() is a nop if the device isn't attached, but this > would be confusing. > > This patch hence moves all the logic of attaching the device, including > the "already attached" check, to a separate vfio_ccw_get_device() function, > counterpart of vfio_put_device(). While here, vfio_put_device() is renamed > to vfio_ccw_put_device() for consistency. > > Based-on: <152311222681.203086.8874800175539040298.stgit@bahia> > Signed-off-by: Greg Kurz <gr...@kaod.org> > --- > v3: - make vfio_ccw_get_device() void and check err in caller > --- > hw/vfio/ccw.c | 56 ++++++++++++++++++++++++++++++++++++-------------------- > 1 file changed, 36 insertions(+), 20 deletions(-)
Thanks, applied.
