Re: [Qemu-devel] [PATCH v4 00/39] Allow configuring the qcow2 L2 cache entry size
On 2018-02-05 15:33, Alberto Garcia wrote: > this is the new revision of the patch series to allow configuring the > entry size of the qcow2 L2 cache. Follow this link for the full > description from the first version: > >https://lists.gnu.org/archive/html/qemu-block/2017-10/msg00458.html > > And here are some numbers showing the performance improvements: > >https://lists.gnu.org/archive/html/qemu-block/2017-12/msg00507.html > > Regards, > > Berto Thanks, applied to my block branch (with s/intead/instead/ and s/=300/=4242/): https://github.com/XanClic/qemu/commits/block Max signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v4 00/39] Allow configuring the qcow2 L2 cache entry size
Am 05.02.2018 um 17:31 hat Max Reitz geschrieben: > On 2018-02-05 15:33, Alberto Garcia wrote: > > this is the new revision of the patch series to allow configuring the > > entry size of the qcow2 L2 cache. Follow this link for the full > > description from the first version: > > > >https://lists.gnu.org/archive/html/qemu-block/2017-10/msg00458.html > > > > And here are some numbers showing the performance improvements: > > > >https://lists.gnu.org/archive/html/qemu-block/2017-12/msg00507.html > > > > Regards, > > > > Berto > > Looks good to me, and all qcow2 iotests pass when the default L2 slice > size is changed (in the code) to 512, so it should be good. > > I'll still give it a couple of days for others to protest. :-) I didn't review the series in detail, but the approach looks sane to me, so no objections from my side. Kevin signature.asc Description: PGP signature
Re: [Qemu-devel] [PATCH v4 00/39] Allow configuring the qcow2 L2 cache entry size
On 2018-02-05 15:33, Alberto Garcia wrote: > this is the new revision of the patch series to allow configuring the > entry size of the qcow2 L2 cache. Follow this link for the full > description from the first version: > >https://lists.gnu.org/archive/html/qemu-block/2017-10/msg00458.html > > And here are some numbers showing the performance improvements: > >https://lists.gnu.org/archive/html/qemu-block/2017-12/msg00507.html > > Regards, > > Berto Looks good to me, and all qcow2 iotests pass when the default L2 slice size is changed (in the code) to 512, so it should be good. I'll still give it a couple of days for others to protest. :-) Max signature.asc Description: OpenPGP digital signature
