Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-02-06 Thread Andrey Smirnov
On Wed, Jan 31, 2018 at 4:13 AM, Marcel Apfelbaum wrote: > On 30/01/2018 19:49, Andrey Smirnov wrote: >> On Tue, Jan 30, 2018 at 5:18 AM, Marcel Apfelbaum >> wrote: >>> Hi Andrei, >>> >>> Sorry for letting you wait, >>> I have some comments/questions

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-01-31 Thread Marcel Apfelbaum
On 30/01/2018 19:49, Andrey Smirnov wrote: > On Tue, Jan 30, 2018 at 5:18 AM, Marcel Apfelbaum > wrote: >> Hi Andrei, >> >> Sorry for letting you wait, >> I have some comments/questions below. >> >> >> On 16/01/2018 3:37, Andrey Smirnov wrote: >>> >>> Add code needed to

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-01-30 Thread Andrey Smirnov
On Tue, Jan 30, 2018 at 5:18 AM, Marcel Apfelbaum wrote: > Hi Andrei, > > Sorry for letting you wait, > I have some comments/questions below. > > > On 16/01/2018 3:37, Andrey Smirnov wrote: >> >> Add code needed to get a functional PCI subsytem when using in >>

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-01-30 Thread Marcel Apfelbaum
Hi Andrei, Sorry for letting you wait, I have some comments/questions below. On 16/01/2018 3:37, Andrey Smirnov wrote: Add code needed to get a functional PCI subsytem when using in conjunction with upstream Linux guest (4.13+). Tested to work against "e1000e" (network adapter, using MSI

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-01-17 Thread Philippe Mathieu-Daudé
Hi Andrey, On Wed, Jan 17, 2018 at 1:12 PM, Andrey Smirnov wrote: > On Wed, Jan 17, 2018 at 7:23 AM, Marcel Apfelbaum > wrote: >> That being said, if Andrey can point me to the PCI spec for the Designware >> PCI host bridge and what parts

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-01-17 Thread Marcel Apfelbaum
On 17/01/2018 18:12, Andrey Smirnov wrote: On Wed, Jan 17, 2018 at 7:23 AM, Marcel Apfelbaum wrote: Hi Peter, On 16/01/2018 16:34, Peter Maydell wrote: On 16 January 2018 at 01:37, Andrey Smirnov wrote: Add code needed to get a

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-01-17 Thread Marcel Apfelbaum
On 17/01/2018 17:35, Peter Maydell wrote: On 17 January 2018 at 15:23, Marcel Apfelbaum wrote: On 16/01/2018 16:34, Peter Maydell wrote: On 16 January 2018 at 01:37, Andrey Smirnov I'm not familiar enough with our PCI code to be able to

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-01-17 Thread Andrey Smirnov
On Wed, Jan 17, 2018 at 7:23 AM, Marcel Apfelbaum wrote: > > Hi Peter, > > > On 16/01/2018 16:34, Peter Maydell wrote: >> >> On 16 January 2018 at 01:37, Andrey Smirnov >> wrote: >>> >>> Add code needed to get a functional PCI subsytem when

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-01-17 Thread Peter Maydell
On 17 January 2018 at 15:23, Marcel Apfelbaum wrote: > > On 16/01/2018 16:34, Peter Maydell wrote: >> On 16 January 2018 at 01:37, Andrey Smirnov >> I'm not familiar enough with our PCI code to be able to review >> this, I'm afraid. MST and

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-01-17 Thread Marcel Apfelbaum
Hi Peter, On 16/01/2018 16:34, Peter Maydell wrote: On 16 January 2018 at 01:37, Andrey Smirnov wrote: Add code needed to get a functional PCI subsytem when using in conjunction with upstream Linux guest (4.13+). Tested to work against "e1000e" (network adapter,

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-01-16 Thread Peter Maydell
On 16 January 2018 at 01:37, Andrey Smirnov wrote: > Add code needed to get a functional PCI subsytem when using in > conjunction with upstream Linux guest (4.13+). Tested to work against > "e1000e" (network adapter, using MSI interrupts) as well as > "usb-ehci" (USB