Re: [Qemu-devel] [PATCH v4 1/2] qapi: allow empty branches in flat unions

2018-06-15 Thread Markus Armbruster
Anton Nefedov writes: > On 14/6/2018 10:19 AM, Markus Armbruster wrote: >> Anton Nefedov writes: >> >>> It often happens that just a few discriminator values imply extra data in >>> a flat union. Existing checks did not make possible to leave other values >>> uncovered. Such cases had to be

Re: [Qemu-devel] [PATCH v4 1/2] qapi: allow empty branches in flat unions

2018-06-14 Thread Anton Nefedov
On 14/6/2018 10:19 AM, Markus Armbruster wrote: Anton Nefedov writes: It often happens that just a few discriminator values imply extra data in a flat union. Existing checks did not make possible to leave other values uncovered. Such cases had to be worked around by either stating a dummy

Re: [Qemu-devel] [PATCH v4 1/2] qapi: allow empty branches in flat unions

2018-06-14 Thread Markus Armbruster
Anton Nefedov writes: > It often happens that just a few discriminator values imply extra data in > a flat union. Existing checks did not make possible to leave other values > uncovered. Such cases had to be worked around by either stating a dummy > (empty) type or introducing another (subset)