Re: [Qemu-devel] [PATCH v4 14/64] target-arm: Use new deposit and extract ops

2016-12-03 Thread Richard Henderson
On 12/01/2016 09:19 AM, Alex Bennée wrote: In fact we seem to have subtly reversed the test here but ri <= si is not exactly equivalent to si >= ri. My version is as follows: /* Recognize simple(r) extractions. */ if (si >= ri) { /* Wd = Wn */ len = (si - ri) + 1;

Re: [Qemu-devel] [PATCH v4 14/64] target-arm: Use new deposit and extract ops

2016-12-01 Thread Alex Bennée
Richard Henderson writes: > Use the new primitives for UBFX and SBFX. > > Signed-off-by: Richard Henderson > --- > target-arm/translate-a64.c | 79 > +++--- > target-arm/translate.c | 37 +- > 2 files changed, 34 insertions(+), 8