Re: [Qemu-devel] [PATCH v4 2/2] Add GE IP-Octal 232 IndustryPack emulation

2013-01-08 Thread Andreas Färber
Am 08.01.2013 02:10, schrieb Alberto Garcia: The GE IP-Octal 232 is an IndustryPack module that implements eight RS-232 serial ports, each one of which can be redirected to a character device in the host. Signed-off-by: Alberto Garcia agar...@igalia.com --- hw/Makefile.objs |2 +-

Re: [Qemu-devel] [PATCH v4 2/2] Add GE IP-Octal 232 IndustryPack emulation

2013-01-08 Thread Alberto Garcia
On Tue, Jan 08, 2013 at 07:08:57PM +0100, Andreas Färber wrote: On my suggestion you changed the type name from ipoctal to ipoctal232 - the file name should probably then be updated, too. For the function prefixes inside the file it shouldn't matter as long as they're consistent. The reason