Re: [Qemu-devel] [PATCH v4 27/49] tests/tcg: enable building for ARM

[Alex Bennée]

Philippe Mathieu-Daudé  writes:

> On 05/17/2018 02:46 PM, Alex Bennée wrote:
>> This allows us to use the docker cross compiler image to build these
>> tests.
>>
>> Signed-off-by: Alex Bennée 
>> ---
>>  tests/tcg/arm/Makefile.include | 8 
>>  1 file changed, 8 insertions(+)
>>  create mode 100644 tests/tcg/arm/Makefile.include
>>
>> diff --git a/tests/tcg/arm/Makefile.include b/tests/tcg/arm/Makefile.include
>> new file mode 100644
>> index 00..8e7eac008f
>> --- /dev/null
>> +++ b/tests/tcg/arm/Makefile.include
>> @@ -0,0 +1,8 @@
>> +# Makefile.include for all ARM targets
>> +#
>> +# We don't have any bigendian build tools so we only use this for armhf
>> +
>> +ifeq ($(TARGET_NAME),arm)
>> +DOCKER_IMAGE=debian-armhf-cross
>
> [Note for a later series:]
> Since this image comes with ARMv7 libraries, I find clearer to rename as
> arm32v7, following new Docker scheme. This will ease to add arm32v6 (and
> arm32v5 if possible...)

I'm not sure if that is worthwhile. Any linux-user build will be ARMv7
or v8 AArch32 and the compilers can always be set to older CPU types.
Testing that we have correct UNDEF behaviour for older CPUs is probably
better handled by things like RISU?

>
>> +DOCKER_CROSS_COMPILER=arm-linux-gnueabihf-gcc
>> +endif
>>
>
> Reviewed-by: Philippe Mathieu-Daudé 
> Tested-by: Philippe Mathieu-Daudé 


--
Alex Bennée

Re: [Qemu-devel] [PATCH v4 27/49] tests/tcg: enable building for ARM

[Philippe Mathieu-Daudé]

On 05/17/2018 02:46 PM, Alex Bennée wrote:
> This allows us to use the docker cross compiler image to build these
> tests.
> 
> Signed-off-by: Alex Bennée 
> ---
>  tests/tcg/arm/Makefile.include | 8 
>  1 file changed, 8 insertions(+)
>  create mode 100644 tests/tcg/arm/Makefile.include
> 
> diff --git a/tests/tcg/arm/Makefile.include b/tests/tcg/arm/Makefile.include
> new file mode 100644
> index 00..8e7eac008f
> --- /dev/null
> +++ b/tests/tcg/arm/Makefile.include
> @@ -0,0 +1,8 @@
> +# Makefile.include for all ARM targets
> +#
> +# We don't have any bigendian build tools so we only use this for armhf
> +
> +ifeq ($(TARGET_NAME),arm)
> +DOCKER_IMAGE=debian-armhf-cross

[Note for a later series:]
Since this image comes with ARMv7 libraries, I find clearer to rename as
arm32v7, following new Docker scheme. This will ease to add arm32v6 (and
arm32v5 if possible...)

> +DOCKER_CROSS_COMPILER=arm-linux-gnueabihf-gcc
> +endif
> 

Reviewed-by: Philippe Mathieu-Daudé 
Tested-by: Philippe Mathieu-Daudé