Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState

2018-02-26 Thread Gerd Hoffmann
Hi, > > The connection between QemuConsole and User Interface (i.e. gtk, spice, > > ...) is a bit more flexible. But also not really designed for hotplug > > as QemuConsole is not hotpluggable in the first place ... > > > > We could drop the display property and use two devices instead. > > >

Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState

2018-02-23 Thread Alex Williamson
On Fri, 23 Feb 2018 09:53:22 +0100 Gerd Hoffmann wrote: > Hi, > > > > What type of device is only sometimes hotpluggable ? > > > The commit message says "display devices" and "consoles", > > > but I would expect those to both be types of device which > > > have a class which is never hotplugga

Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState

2018-02-23 Thread Gerd Hoffmann
Hi, > > What type of device is only sometimes hotpluggable ? > > The commit message says "display devices" and "consoles", > > but I would expect those to both be types of device which > > have a class which is never hotpluggable, so you can mark > > them non-hotpluggable with the existing class

Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState

2018-02-22 Thread Zhenyu Wang
On 2018.02.22 09:59:17 -0700, Alex Williamson wrote: > On Thu, 22 Feb 2018 15:46:17 + > Peter Maydell wrote: > > > On 22 February 2018 at 15:37, Gerd Hoffmann wrote: > > > On Mon, Feb 19, 2018 at 12:14:55PM +0100, Gerd Hoffmann wrote: > > >> vfio display support wants disable hotplug for c

Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState

2018-02-22 Thread Peter Maydell
On 22 February 2018 at 16:59, Alex Williamson wrote: > On Thu, 22 Feb 2018 15:46:17 + > Peter Maydell wrote: >> What type of device is only sometimes hotpluggable ? >> The commit message says "display devices" and "consoles", >> but I would expect those to both be types of device which >> hav

Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState

2018-02-22 Thread Alex Williamson
On Thu, 22 Feb 2018 15:46:17 + Peter Maydell wrote: > On 22 February 2018 at 15:37, Gerd Hoffmann wrote: > > On Mon, Feb 19, 2018 at 12:14:55PM +0100, Gerd Hoffmann wrote: > >> vfio display support wants disable hotplug for certain devices, because > >> qemu doesn't support hotplugging dis

Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState

2018-02-22 Thread Peter Maydell
On 22 February 2018 at 15:37, Gerd Hoffmann wrote: > On Mon, Feb 19, 2018 at 12:14:55PM +0100, Gerd Hoffmann wrote: >> vfio display support wants disable hotplug for certain devices, because >> qemu doesn't support hotplugging display devices and qemu consoles. >> >> Add a hotpluggable bool to Dev

Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState

2018-02-22 Thread Gerd Hoffmann
On Mon, Feb 19, 2018 at 12:14:55PM +0100, Gerd Hoffmann wrote: > vfio display support wants disable hotplug for certain devices, because > qemu doesn't support hotplugging display devices and qemu consoles. > > Add a hotpluggable bool to DeviceState, initialize it from > DeviceClass->hotpluggable,