Re: [Qemu-devel] [PATCH v4 9/9] qapi: Add NVMe driver options to the schema

2018-01-11 Thread Fam Zheng 
On Wed, 01/10 08:41, Eric Blake wrote:
> On 01/10/2018 03:18 AM, Fam Zheng wrote:
> > Signed-off-by: Fam Zheng 
> > ---
> >  qapi/block-core.json | 16 +++-
> >  1 file changed, 15 insertions(+), 1 deletion(-)
> > 
> > diff --git a/qapi/block-core.json b/qapi/block-core.json
> > index e94a6881b2..fd6c94454d 100644
> > --- a/qapi/block-core.json
> > +++ b/qapi/block-core.json
> > @@ -2237,7 +2237,7 @@
> >'data': [ 'blkdebug', 'blkverify', 'bochs', 'cloop',
> >  'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom',
> >  'host_device', 'http', 'https', 'iscsi', 'luks', 'nbd', 'nfs',
> > -'null-aio', 'null-co', 'parallels', 'qcow', 'qcow2', 'qed',
> > +'null-aio', 'null-co', 'nvme', 'parallels', 'qcow', 'qcow2', 
> > 'qed',
> >  'quorum', 'raw', 'rbd', 'replication', 'sheepdog', 'ssh',
> >  'throttle', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat', 'vxhs' ] }
> 
> Missing a doc line:
> @nvme: Since 2.12
> 

Will add, thanks!

Fam

Re: [Qemu-devel] [PATCH v4 9/9] qapi: Add NVMe driver options to the schema

2018-01-10 Thread Stefan Hajnoczi 
On Wed, Jan 10, 2018 at 05:18:46PM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng 
> ---
>  qapi/block-core.json | 16 +++-
>  1 file changed, 15 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi 


signature.asc
Description: PGP signature

Re: [Qemu-devel] [PATCH v4 9/9] qapi: Add NVMe driver options to the schema

2018-01-10 Thread Eric Blake 
On 01/10/2018 03:18 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng 
> ---
>  qapi/block-core.json | 16 +++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index e94a6881b2..fd6c94454d 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2237,7 +2237,7 @@
>'data': [ 'blkdebug', 'blkverify', 'bochs', 'cloop',
>  'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom',
>  'host_device', 'http', 'https', 'iscsi', 'luks', 'nbd', 'nfs',
> -'null-aio', 'null-co', 'parallels', 'qcow', 'qcow2', 'qed',
> +'null-aio', 'null-co', 'nvme', 'parallels', 'qcow', 'qcow2', 
> 'qed',
>  'quorum', 'raw', 'rbd', 'replication', 'sheepdog', 'ssh',
>  'throttle', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat', 'vxhs' ] }

Missing a doc line:
@nvme: Since 2.12

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



signature.asc
Description: OpenPGP digital signature