Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

Hi, I have submitted a new patch (V6) after fixing the problem of libqnioshim referencing symbols from inside qemu vxhs.c code. (1) libqnioshim code has now been brought inside vxhs.c (2) vxhs.c now needs to link only with libqnio.so. (3) libqnio.so does not have any unreferenced symbols coming

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

>> Yes, qemu_iio_ioctl(VDISK_AIO_FLUSH) is only a place-holder at present >> in case we later want to add some functionality to it. I have now >> added a comment to this affect to avoid any confusion. >> > > The problem is you don't know which version of the qnio library any given > QEMU binary

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

On Wed, Sep 07, 2016 at 03:32:47PM -0700, ashish mittal wrote: > Hi Jeff, > > Thank you for the comments and corrections. > > I have submitted a v5 patch after incorporating most of your review > comments. Please find details in-line. > > Thanks, > Ashish > > On Tue, Aug 30, 2016 at 10:35 AM,

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

On Thu, Sep 08, 2016 at 10:34:24AM +0100, Daniel P. Berrange wrote: > On Thu, Sep 08, 2016 at 11:29:41AM +0200, Kevin Wolf wrote: > > Am 08.09.2016 um 10:49 hat Daniel P. Berrange geschrieben: > > > On Thu, Sep 08, 2016 at 10:43:19AM +0200, Kevin Wolf wrote: > > > > Am 08.09.2016 um 00:32 hat

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

On 08/09/2016 12:18, Kevin Wolf wrote: > Am 08.09.2016 um 11:43 hat Daniel P. Berrange geschrieben: >> On Thu, Sep 08, 2016 at 11:29:41AM +0200, Kevin Wolf wrote: >>> Am 08.09.2016 um 10:49 hat Daniel P. Berrange geschrieben: On Thu, Sep 08, 2016 at 10:43:19AM +0200, Kevin Wolf wrote: >

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

Am 08.09.2016 um 10:49 hat Daniel P. Berrange geschrieben: > On Thu, Sep 08, 2016 at 10:43:19AM +0200, Kevin Wolf wrote: > > Am 08.09.2016 um 00:32 hat ashish mittal geschrieben: > > > >> + > > > >> +void vxhs_set_acb_buffer(void *ptr, void *buffer) > > > >> +{ > > > >> +VXHSAIOCB *acb = ptr;

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

Am 08.09.2016 um 11:43 hat Daniel P. Berrange geschrieben: > On Thu, Sep 08, 2016 at 11:29:41AM +0200, Kevin Wolf wrote: > > Am 08.09.2016 um 10:49 hat Daniel P. Berrange geschrieben: > > > On Thu, Sep 08, 2016 at 10:43:19AM +0200, Kevin Wolf wrote: > > > > Am 08.09.2016 um 00:32 hat ashish mittal

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

On Thu, Sep 08, 2016 at 11:29:41AM +0200, Kevin Wolf wrote: > Am 08.09.2016 um 10:49 hat Daniel P. Berrange geschrieben: > > On Thu, Sep 08, 2016 at 10:43:19AM +0200, Kevin Wolf wrote: > > > Am 08.09.2016 um 00:32 hat ashish mittal geschrieben: > > > > >> + > > > > >> +void

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

On Thu, Sep 08, 2016 at 11:29:41AM +0200, Kevin Wolf wrote: > Am 08.09.2016 um 10:49 hat Daniel P. Berrange geschrieben: > > On Thu, Sep 08, 2016 at 10:43:19AM +0200, Kevin Wolf wrote: > > > Am 08.09.2016 um 00:32 hat ashish mittal geschrieben: > > > > >> + > > > > >> +void

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

Am 08.09.2016 um 00:32 hat ashish mittal geschrieben: > >> + > >> +void vxhs_set_acb_buffer(void *ptr, void *buffer) > >> +{ > >> +VXHSAIOCB *acb = ptr; > >> + > >> +acb->buffer = buffer; > >> +} > >> + > > > > Unused function? > > This is called from within libqnio. Wait, you mean the

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

On Thu, Sep 08, 2016 at 10:43:19AM +0200, Kevin Wolf wrote: > Am 08.09.2016 um 00:32 hat ashish mittal geschrieben: > > >> + > > >> +void vxhs_set_acb_buffer(void *ptr, void *buffer) > > >> +{ > > >> +VXHSAIOCB *acb = ptr; > > >> + > > >> +acb->buffer = buffer; > > >> +} > > >> + > > > > >

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

Hi Jeff, Thank you for the comments and corrections. I have submitted a v5 patch after incorporating most of your review comments. Please find details in-line. Thanks, Ashish On Tue, Aug 30, 2016 at 10:35 AM, Jeff Cody wrote: > > First-pass-over-the-code review: > > On Mon,

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

On Mon, 08/22 23:56, Ashish Mittal wrote: > block/Makefile.objs |2 + > block/trace-events | 41 ++ > block/vxhs.c| 1304 > +++ > block/vxhs.h| 237 ++ > configure | 50 ++ If vxhs code is contained in

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

First-pass-over-the-code review: On Mon, Aug 22, 2016 at 11:56:30PM -0700, Ashish Mittal wrote: > This patch adds support for a new block device type called "vxhs". > Source code for the library that this code loads can be downloaded from: > https://github.com/MittalAshish/libqnio.git > >