Re: [Qemu-devel] [PATCH v6 1/7] linux-user: Fix TARGET_SIOCATMARK definition for Mips

[Aleksandar Markovic]

Thanks a lot for the review, Laurent, I am going to add TARGET_SH4 and 
TARGET_ALPHA to this change.

I test LTP syscall test set on mips, arm and intel platforms as my regression 
tests, but also some number of individual LTP tests (the choice of tests 
depends on the change) on more platforms, and minimal test examples 
illustrating the bug and the fix as well.

Aleksandar

From: Laurent Vivier [laur...@vivier.eu]
Sent: Friday, September 16, 2016 11:22 AM
To: Aleksandar Markovic; qemu-devel@nongnu.org; riku.voi...@iki.fi; 
peter.mayd...@linaro.org; aurel...@aurel32.net; Leon Alrae; Petar Jovanovic; 
Miodrag Dinic; Aleksandar Rikalo; Aleksandar Markovic
Subject: Re: [Qemu-devel] [PATCH v6 1/7] linux-user: Fix TARGET_SIOCATMARK 
definition for Mips

Le 16/09/2016 à 13:14, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic <aleksandar.marko...@imgtec.com>
>
> This patch fixes wrong definition of TARGET_SIOCATMARK for Mips.
>
> The current definition is:
>
>   #define SIOCATMARK  0x8905
>
> while the correct definition is:
>
>   #define SIOCATMARK  TARGET_IOR('s', 7, int)

According to linux sources, it seems true also for alpha and sh4.

Perhaps you can add them to the patch?
Do you have something to test it doesn't break anything?

Thanks,
Laurent

Re: [Qemu-devel] [PATCH v6 1/7] linux-user: Fix TARGET_SIOCATMARK definition for Mips

[Laurent Vivier]

Le 16/09/2016 à 13:14, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic 
> 
> This patch fixes wrong definition of TARGET_SIOCATMARK for Mips.
> 
> The current definition is:
> 
>   #define SIOCATMARK  0x8905
> 
> while the correct definition is:
> 
>   #define SIOCATMARK  TARGET_IOR('s', 7, int)

According to linux sources, it seems true also for alpha and sh4.

Perhaps you can add them to the patch?
Do you have something to test it doesn't break anything?

Thanks,
Laurent