On Sat, Jul 29, 2017 at 11:18:18PM +0200, Knut Omang wrote: > If an offset of ports is specified to the inet_listen_saddr function(), > and two or more processes tries to bind from these ports at the same time, > occasionally more than one process may be able to bind to the same > port. The condition is detected by listen() but too late to avoid a failure. > > This function is called by socket_listen() and used > by all socket listening code in QEMU, so all cases where any form of dynamic > port selection is used should be subject to this issue. > > Add code to close and re-establish the socket when this > condition is observed, hiding the race condition from the user. > > Also clean up some issues with error handling to allow more > accurate reporting of the cause of an error. > > This has been developed and tested by means of the > test-listen unit test in the previous commit. > Enable the test for make check now that it passes. > > Reviewed-by: Bhavesh Davda <bhavesh.da...@oracle.com> > Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> > Reviewed-by: Girish Moodalbail <girish.moodalb...@oracle.com> > Signed-off-by: Knut Omang <knut.om...@oracle.com> > --- > tests/Makefile.include | 2 +- > util/qemu-sockets.c | 58 ++++++++++++++++++++++++++++++------------- > 2 files changed, 42 insertions(+), 18 deletions(-)
Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|