Re: [Qemu-devel] [PATCH v7 1/6] throttle: factor out duplicate code

2017-08-07 Thread Pradeep Jagadeesh
On 7/10/2017 4:41 PM, Eric Blake wrote: On 07/04/2017 10:30 AM, Pradeep Jagadeesh wrote: This patch factor out the duplicate throttle code that was present in s/This patch factor/Factor/ It's okay to write commit messages in the imperative tense; the easiest way I know to start a good message

Re: [Qemu-devel] [PATCH v7 1/6] throttle: factor out duplicate code

2017-07-10 Thread Eric Blake
On 07/04/2017 10:30 AM, Pradeep Jagadeesh wrote: > This patch factor out the duplicate throttle code that was present in s/This patch factor/Factor/ It's okay to write commit messages in the imperative tense; the easiest way I know to start a good message is to use an implied "Apply this patch to

Re: [Qemu-devel] [PATCH v7 1/6] throttle: factor out duplicate code

2017-07-10 Thread Greg Kurz
On Tue, 4 Jul 2017 11:30:58 -0400 Pradeep Jagadeesh wrote: > This patch factor out the duplicate throttle code that was present in > block and fsdev devices. > > Signed-off-by: Pradeep Jagadeesh > Reviewed-by: Alberto Garcia > --- Reviewed-by: Greg Kurz > blockdev.c |