Re: [Qemu-devel] [PATCH v9 00/27] gdbstub: Refactor command packets handler

2019-05-16 Thread Alex Bennée
Alex Bennée writes: > Jon Doron writes: > >> This patch series refactors the old gdbstub command packets handler >> with a new infrastructure which should ease extending and adding new >> and missing gdb command packets. > > Jon, > > > Finally it would be nice if we could modernise the membuf

Re: [Qemu-devel] [PATCH v9 00/27] gdbstub: Refactor command packets handler

2019-05-15 Thread Alex Bennée
Jon Doron writes: > This patch series refactors the old gdbstub command packets handler > with a new infrastructure which should ease extending and adding new > and missing gdb command packets. Jon, I've finished my review and things are looking pretty good. The code is a good clean-up and ma

Re: [Qemu-devel] [PATCH v9 00/27] gdbstub: Refactor command packets handler

2019-05-15 Thread Alex Bennée
Jon Doron writes: > This patch series refactors the old gdbstub command packets handler > with a new infrastructure which should ease extending and adding new > and missing gdb command packets. There seems to be some compiler errors and variants that this breaks the CI on: https://travis-ci