Re: [Qemu-devel] [PULL 00/25] target-arm queue
On 20 August 2018 at 11:31, Peter Maydell wrote: > Some more outstanding target-arm patches; nothing terribly > exciting. Mostly they're mine; I'm trying to reduce the > number of patches I still have in flight, so I've picked > out some of the reviewed patches from a couple of sets I've > sent out and will resend v2 versions of those sets with the > remaining patches with fixes for issues noted in review once > this is in master. > > thanks > -- PMM > > > The following changes since commit adaec191bfb31e12d40af8ab1b869f5b40d61ee9: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-08-20 > 09:48:03 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20180820 > > for you to fetch changes up to b85fad1588e812566f897f747e38da345a7016d6: > > hw/dma/pl080: Remove hw_error() if DMA is enabled (2018-08-20 11:24:33 > +0100) > > > target-arm queue: > * Fix crash on conditional instruction in an IT block > * docs/generic-loader: mention U-Boot and Intel HEX executable formats > * hw/intc/arm_gicv3_its: downgrade error_report to warn_report in > kvm_arm_its_reset > * imx_serial: Generate interrupt on receive data ready if enabled > * Fix various minor bugs in AArch32 Hyp related coprocessor registers > * Permit accesses to ELR_Hyp from Hyp mode via MSR/MRS (banked) > * Implement AArch32 ERET instruction > * hw/arm/virt: Add virt-3.1 machine type > * sdhci: add i.MX SD Stable Clock bit > * Remove now-obsolete MMIO request_ptr APIs > * hw/timer/m48t59: Move away from old_mmio accessors > * hw/watchdog/cmsdk_apb_watchdog: Implement CMSDK APB watchdog module > * nvic: Expose NMI line > * hw/dma/pl080: cleanups and new features required for use in MPS boards > Applied, thanks. -- PMM
Re: [Qemu-devel] [PULL 00/25] target-arm queue
On 31 May 2018 at 17:00, Peter Maydell wrote: > target-arm queue. This has the "plumb txattrs through various > bits of exec.c" patches, and a collection of bug fixes from > various people. > > v2: fix compile error on arm hosts... > > thanks > -- PMM > > > The following changes since commit a3ac12fba028df90f7b3dbec924995c126c41022: > > Merge remote-tracking branch 'remotes/ehabkost/tags/numa-next-pull-request' > into staging (2018-05-31 11:12:36 +0100) > > are available in the Git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20180531-1 > > for you to fetch changes up to 2f15b79280cf71b7991dfd3f0312a1797630e376: > > KVM: GIC: Fix memory leak due to calling kvm_init_irq_routing twice > (2018-05-31 16:32:35 +0100) > Applied, thanks. -- PMM
Re: [Qemu-devel] [PULL 00/25] target-arm queue
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180531142357.904-1-peter.mayd...@linaro.org
Subject: [Qemu-devel] [PULL 00/25] target-arm queue
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
fe817a8a0d..a3ac12fba0 master -> master
t [tag update]
patchew/1527736557-11084-1-git-send-email-zhaoshengl...@huawei.com ->
patchew/1527736557-11084-1-git-send-email-zhaoshengl...@huawei.com
* [new tag]
patchew/20180531142357.904-1-peter.mayd...@linaro.org ->
patchew/20180531142357.904-1-peter.mayd...@linaro.org
Switched to a new branch 'test'
a487bba092 KVM: GIC: Fix memory leak due to calling kvm_init_irq_routing twice
5a3bf5043e ARM: ACPI: Fix use-after-free due to memory realloc
676e28bdf5 vmstate.h: Provide VMSTATE_BOOL_SUB_ARRAY
d7aae0ee61 Make address_space_translate_iommu take a MemTxAttrs argument
12bb5f653d Make flatview_do_translate() take a MemTxAttrs argument
8a6e14496d Make address_space_get_iotlb_entry() take a MemTxAttrs argument
9cac582143 Make flatview_translate() take a MemTxAttrs argument
55db02aca6 Make flatview_access_valid() take a MemTxAttrs argument
f87f897086 Make MemoryRegion valid.accepts callback take a MemTxAttrs argument
9aa53aa0d4 Make memory_region_access_valid() take a MemTxAttrs argument
7b418bb6cf Make flatview_extend_translation() take a MemTxAttrs argument
377f13129d Make address_space_access_valid() take a MemTxAttrs argument
0649977ea0 Make address_space_map() take a MemTxAttrs argument
aa2f49abf1 Make address_space_translate{, _cached}() take a MemTxAttrs argument
105bf37846 Make tb_invalidate_phys_addr() take a MemTxAttrs argument
73b69cf0cd memory.h: Improve IOMMU related documentation
0031fdaa47 Correct CPACR reset value for v7 cores
0926c82acb xlnx-zdma: Correct mem leaks and memset to zero on desc unaligned
errors
48374ca065 arm: fix malloc type mismatch
427a2da078 arm: fix qemu crash on startup with -bios option
fe5e7fe927 tcg: Fix helper function vs host abi for float16
726e508937 arm_gicv3_kvm: increase clroffset accordingly
b6fb16391d hw/intc/arm_gicv3: Fix APxR register dispatching
420d87bf34 MAINTAINERS: Add entries for newer MPS2 boards and devices
101898757f target/arm: Honour FPCR.FZ in FRECPX
=== OUTPUT BEGIN ===
Checking PATCH 1/25: target/arm: Honour FPCR.FZ in FRECPX...
Checking PATCH 2/25: MAINTAINERS: Add entries for newer MPS2 boards and
devices...
Checking PATCH 3/25: hw/intc/arm_gicv3: Fix APxR register dispatching...
Checking PATCH 4/25: arm_gicv3_kvm: increase clroffset accordingly...
Checking PATCH 5/25: tcg: Fix helper function vs host abi for float16...
ERROR: space prohibited before that close parenthesis ')'
#242: FILE: target/arm/helper.c:11367:
+CONV_FTOI(vfp_to##name##p, ftype, fsz, sign, )\
ERROR: space prohibited before that close parenthesis ')'
#251: FILE: target/arm/helper.c:11370:
+FLOAT_CONVS(si, h, uint32_t, 16, )
ERROR: space prohibited before that close parenthesis ')'
#252: FILE: target/arm/helper.c:11371:
+FLOAT_CONVS(si, s, float32, 32, )
ERROR: space prohibited before that close parenthesis ')'
#253: FILE: target/arm/helper.c:11372:
+FLOAT_CONVS(si, d, float64, 64, )
total: 4 errors, 0 warnings, 312 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/25: arm: fix qemu crash on startup with -bios option...
Checking PATCH 7/25: arm: fix malloc type mismatch...
Checking PATCH 8/25: xlnx-zdma: Correct mem leaks and memset to zero on desc
unaligned errors...
Checking PATCH 9/25: Correct CPACR reset value for v7 cores...
Checking PATCH 10/25: memory.h: Improve IOMMU related documentation...
Checking PATCH 11/25: Make tb_invalidate_phys_addr() take a MemTxAttrs
argument...
Checking PATCH 12/25: Make address_space_translate{, _cached}() take a
MemTxAttrs argument...
Checking PATCH 13/25: Make address_space_map() take a MemTxAttrs argument...
Checking PATCH 14/25: Make address_space_access_valid() take a MemTxAttrs
argument...
Checking PATCH 15/25: Make flatview_extend_translation() take a MemTxAttrs
argument...
Checking PATCH 16/25: Make memory_region_access_valid() take a MemTxAttrs
argument...
Checking PATCH 17/25: Make MemoryRegion valid.accepts callback take a
MemTxAttrs argument.
Re: [Qemu-devel] [PULL 00/25] target-arm queue
On 31 May 2018 at 15:23, Peter Maydell wrote:
> target-arm queue. This has the "plumb txattrs through various
> bits of exec.c" patches, and a collection of bug fixes from
> various people.
>
> thanks
> -- PMM
>
>
>
> The following changes since commit a3ac12fba028df90f7b3dbec924995c126c41022:
>
> Merge remote-tracking branch 'remotes/ehabkost/tags/numa-next-pull-request'
> into staging (2018-05-31 11:12:36 +0100)
>
> are available in the Git repository at:
>
> git://git.linaro.org/people/pmaydell/qemu-arm.git
> tags/pull-target-arm-20180531
>
> for you to fetch changes up to 49d1dca0520ea71bc21867fab6647f474fcf857b:
>
> KVM: GIC: Fix memory leak due to calling kvm_init_irq_routing twice
> (2018-05-31 14:52:53 +0100)
>
Patch "Make address_space_translate{, _cached}() take a MemTxAttrs argument"
needs this squashed into it:
--- a/target/arm/kvm.c
+++ b/target/arm/kvm.c
@@ -664,7 +664,8 @@ int kvm_arch_fixup_msi_route(struct
kvm_irq_routing_entry *route,
/* MSI doorbell address is translated by an IOMMU */
rcu_read_lock();
-mr = address_space_translate(as, address, &xlat, &len, true);
+mr = address_space_translate(as, address, &xlat, &len, true,
+ MEMTXATTRS_UNSPECIFIED);
if (!mr) {
goto unlock;
}
to avoid a compile failure on arm hosts.
-- PMM
Re: [Qemu-devel] [PULL 00/25] target-arm queue
On 9 March 2018 at 17:25, Peter Maydell wrote: > Arm pullreq for the 2.12 codefreeze... > > thanks > -- PMM > > The following changes since commit b39b61e410022f96ceb53d4381d25cba5126ac44: > > memory: fix flatview_access_valid RCU read lock/unlock imbalance > (2018-03-09 15:55:20 +) > > are available in the Git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20180309 > > for you to fetch changes up to 076a0fc32a73a9b960e0f73f04a531bc1bd94308: > > MAINTAINERS: Add entries for SD (SDHCI, SDBus, SDCard) (2018-03-09 17:09:45 > +) > > > target-arm queue: > * i.MX: Add i.MX7 SOC implementation and i.MX7 Sabre board > * Report the correct core count in A53 L2CTLR on the ZynqMP board > * linux-user: preliminary SVE support work (signal handling) > * hw/arm/boot: fix memory leak in case of error loading ELF file > * hw/arm/boot: avoid reading off end of buffer if passed very >small image file > * hw/arm: Use more CONFIG switches for the object files > * target/arm: Add "-cpu max" support > * hw/arm/virt: Support -machine gic-version=max > * hw/sd: improve debug tracing > * hw/sd: sdcard: Add the Tuning Command (CMD 19) > * MAINTAINERS: add Philippe as odd-fixes maintainer for SD > > Applied, thanks. -- PMM
Re: [Qemu-devel] [PULL 00/25] target-arm queue
On 27 December 2016 at 15:20, Peter Maydell wrote: > First target-arm pull for 2.9; nothing particularly exciting here. > > thanks > -- PMM > > The following changes since commit a470b33259bf82ef2336bfcd5d07640562d3f63b: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2016-12-22 19:23:51 +) > > are available in the git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20161227 > > for you to fetch changes up to 91db4642f868cf2e591b62d31a19d35b02ea791e: > > target-arm: Add VBAR support to ARM1176 CPUs (2016-12-27 14:59:30 +) > > Applied, thanks. -- PMM
Re: [Qemu-devel] [PULL 00/25] target-arm queue
On 17 October 2016 at 19:40, Peter Maydell wrote: > Random mix of stuff here, nothing in particular > very large. Includes a fix for the regression running > Thumb userspace code. > > thanks > -- PMM > > > The following changes since commit 0975b8b823a888d474fa33821dfe84e6904db197: > > Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging > (2016-10-17 16:17:51 +0100) > > are available in the git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20161017 > > for you to fetch changes up to 041ac05672993ff33a15f8017c0f729ca6dfad73: > > hw/char/pl011: Add trace events (2016-10-17 19:32:44 +0100) > > > target-arm: > * target-arm: kvm: use AddressSpace-specific listener > * aspeed: add SMC controllers > * hw/arm/boot: allow using a command line specified dtb without a kernel > * hw/dma/pl080: Fix bad bit mask > * hw/intc/arm_gic_kvm: Fix build on aarch64 with some compilers > * hw/arm/virt: fix ACPI tables for ITS > * tests: add a m25p80 test > * tests: cleanup ptimer-test > * pxa2xx: Auto-assign name for i2c bus in i2c_init_bus > * target-arm: handle tagged addresses in A64 code > * target-arm: Fix masking of PC lower bits when doing exception returns > * target-arm: Implement dummy MDCCINT_EL1 > * target-arm: Add trace events for the generic timers > * hw/intc/arm_gicv3: Fix ICC register tracepoints > * hw/char/pl011: Add trace events Applied, thanks. -- PMM
Re: [Qemu-devel] [PULL 00/25] target-arm queue
On 17 December 2015 at 13:40, Peter Maydell wrote: > On 17 December 2015 at 11:49, Peter Maydell wrote: >> First target-arm pull for 2.6. I have a bunch more stuff in my >> to-review queue, but this is big enough for a pull already. >> >> -- PMM >> >> The following changes since commit fc77eb20d78e303ef11482288e185d856431f02f: >> >> Merge remote-tracking branch 'remotes/kraxel/tags/pull-audio-20151215-1' >> into staging (2015-12-17 11:10:03 +) >> >> are available in the git repository at: >> >> >> git://git.linaro.org/people/pmaydell/qemu-arm.git >> tags/pull-target-arm-20151217 > > Updated: > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20151217-1 > > to fix a build issue due to including a linux header directly > rather than the standard-includes/linux local version. Fixed version applied. -- PMM
Re: [Qemu-devel] [PULL 00/25] target-arm queue
On 17 December 2015 at 11:49, Peter Maydell wrote: > First target-arm pull for 2.6. I have a bunch more stuff in my > to-review queue, but this is big enough for a pull already. > > -- PMM > > The following changes since commit fc77eb20d78e303ef11482288e185d856431f02f: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-audio-20151215-1' > into staging (2015-12-17 11:10:03 +) > > are available in the git repository at: > > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20151217 Updated: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20151217-1 to fix a build issue due to including a linux header directly rather than the standard-includes/linux local version. thanks -- PMM
