Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes
On 05/23/19 10:37, Peter Maydell wrote: > On Thu, 23 May 2019 at 01:51, Laszlo Ersek wrote: >> I have narrowed down the issue sufficiently that I think I can hand >> it over to Peter and Ard now -- because they know AARCH32 and AARCH64 >> assembly, and "target/arm/translate-a64.c" and "tcg/arm/*" too. >> >> The summarize the issue for Ard, the symptom is that AARCH64 >> ArmVirtQemu runs perfectly fine with TCG on an x86-64 system, but it >> crashes on an AARCH32 host system. > > Thanks for the investigation; this is probably more one for Richard > than me. I figured I'd provide some logs. (1) To recap, the aarch64 assembly source code file that seems to be mis-translated (from the aarch64 binary) lives at https://github.com/tianocore/edk2/blob/3604174718e2afc950c3cc64c64ba5165c8692bd/MdePkg/Library/BaseMemoryLibOptDxe/AArch64/CopyMem.S The relevant functions are InternalMemCopyMem() and __memcpy(). (2) I disassembled the aarch64 binary with "objdump", and uploaded the listing to: http://people.redhat.com/lersek/aarch64-to-arm-mistranslation/DxeCore.objdump.xz The InternalMemCopyMem() function starts at hex offset 2b2ec. The __memcpy() function starts at hex offset 2b180. (3) I ran the guest with "-d in_asm,op,op_opt,op_ind,out_asm" and uploaded the log file to: http://people.redhat.com/lersek/aarch64-to-arm-mistranslation/tcg.in_asm.op.op_opt.op_ind.out_asm.log.xz The TBs that correspond to (parts of) the InternalMemCopyMem() and __memcpy() functions are scattered over the file, but the offset between the "nice" disassembly from (2), and the in-RAM TBs in (3), can be determined from the fact that there is a single prfm instruction in the entire binary. The instruction's offset is 0x2b180 in (2) -- at the beginning of the __memcpy() function --, and its RAM address is 0x472d2180 in (3). Thus the difference (= the load address of DxeCore.efi) is 0x472a7000. (This is logged by the guest as well: > Loading DXE CORE at 0x000472A7000 EntryPoint=0x000472A8000 ) Thanks Laszlo
Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes
Hi Peter, On 05/22/19 23:15, Peter Maydell wrote: > On Wed, 22 May 2019 at 15:22, Laszlo Ersek wrote: >> This is very interesting. I had obviously tested booting >> "bios-tables-test.aarch64.iso.qcow2" against "edk2-aarch64-code.fd", >> using TCG, on my x86_64 laptop. (And, I've run the above exact command >> just now, at commit a4f667b67149 -- it works 100% fine.) >> >> However, I've never been *near* a 32-bit ARM host. Therefore my >> suspicion is that the AARCH64 UEFI guest code tickles something in the >> 32-bit ARM code generator. It could be a bug in 32-bit ARM TCG, or it >> could be a bug in edk2 that is exposed by 32-bit ARM TCG. > > Does it repro in a 32-bit-chroot in an aarch64 host ? > I don't know if that might be easier for you to set up than > getting access to real 32-bit hardware. If this test is still necessary (e.g. for repeated testing), I might be able to run qemu-system-aarch64/TCG in a 32-bit QEMU/KVM guest on my Mustang. I was preparing to set up this kind of nesting, when Igor gave me access to a real aarch32 host. Thanks Laszlo
Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes
On Thu, 23 May 2019 at 01:51, Laszlo Ersek wrote: > I have narrowed down the issue sufficiently that I think I can hand it > over to Peter and Ard now -- because they know AARCH32 and AARCH64 > assembly, and "target/arm/translate-a64.c" and "tcg/arm/*" too. > > The summarize the issue for Ard, the symptom is that AARCH64 ArmVirtQemu > runs perfectly fine with TCG on an x86-64 system, but it crashes on an > AARCH32 host system. Thanks for the investigation; this is probably more one for Richard than me. -- PMM
Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes
(+Ard)
On 05/22/19 16:22, Laszlo Ersek wrote:
> On 05/22/19 15:06, Igor Mammedov wrote:
>> On Tue, 21 May 2019 09:26:16 -0400
>> "Michael S. Tsirkin" wrote:
>>
>>> On Tue, May 21, 2019 at 12:49:48PM +0100, Peter Maydell wrote:
On Tue, 21 May 2019 at 00:10, Michael S. Tsirkin
wrote:
>
> The following changes since commit
> 2259637b95bef3116cc262459271de08e038cc66:
>
> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream'
> into staging (2019-05-20 17:22:05 +0100)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git
> tags/for_upstream
>
> for you to fetch changes up to
> 0c05ec64c388aea59facbef740651afa78e04f50:
>
> tests: acpi: print error unable to dump ACPI table during
> rebuild (2019-05-20 18:40:02 -0400)
>
>
> pci, pc, virtio: features, fixes
>
> reconnect for vhost blk
> tests for UEFI
> misc other stuff
>
> Signed-off-by: Michael S. Tsirkin
>
>
Hi -- this failed 'make check' for 32-bit Arm hosts:
ERROR:/home/peter.maydell/qemu/tests/acpi-utils.c:145:acpi_find_rsdp_address_uefi:
code should not be reached
Aborted
ERROR - too few tests run (expected 1, got 0)
/home/peter.maydell/qemu/tests/Makefile.include:885: recipe for
/target check-qtest-aarch64' failed
thanks
-- PMM
>>>
>>> Nothing jumps out ... Igor?
>> On 32-bit ARM host and it looks like UEFI crashes (CCing Laszlo)
>> with:
>>
>> InstallProtocolInterface: 5B1B31A1-9562-11D2-8E3F-00A0C969723B 469E52C0
>> ASSERT [DxeCore]
>> /home/lacos/src/upstream/qemu/roms/edk2/MdePkg/Library/BaseLib/String.c(1090):
>> Length < _gPcd_FixedAtBuild_PcdMaximumAsciiStringLength
>>
>> CLI to reproduce:
>>
>> qemu-system-aarch64 -display none -machine virt,accel=tcg
>> -nodefaults -nographic -drive
>> if=pflash,format=raw,file=pc-bios/edk2-aarch64-code.fd,readonly
>> -drive if=pflash,format=raw,file=pc-bios/edk2-arm-vars.fd,snapshot=on
>> -cdrom tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.qcow2
>> -cpu cortex-a57 -serial stdio
>
> This is very interesting. I had obviously tested booting
> "bios-tables-test.aarch64.iso.qcow2" against "edk2-aarch64-code.fd",
> using TCG, on my x86_64 laptop. (And, I've run the above exact command
> just now, at commit a4f667b67149 -- it works 100% fine.)
>
> However, I've never been *near* a 32-bit ARM host. Therefore my
> suspicion is that the AARCH64 UEFI guest code tickles something in the
> 32-bit ARM code generator. It could be a bug in 32-bit ARM TCG, or it
> could be a bug in edk2 that is exposed by 32-bit ARM TCG.
>
> The direct assertion failure is mostly useless. The AsciiStrLen()
> function does what you'd expect it to, except it has a kind of "safety
> check" where it trips an assertion if the string length (under
> measurement) exceeds a pre-set platform constant. It helps with
> catching memory corruption errors.
>
> $ git show edk2-stable201903:MdePkg/Library/BaseLib/String.c | less
> 1090g
>
> UINTN
> EFIAPI
> AsciiStrLen (
> IN CONST CHAR8 *String
> )
> {
> UINTN Length;
>
> ASSERT (String != NULL);
>
> for (Length = 0; *String != '\0'; String++, Length++) {
> //
> // If PcdMaximumUnicodeStringLength is not zero,
> // length should not more than PcdMaximumUnicodeStringLength
> //
> if (PcdGet32 (PcdMaximumAsciiStringLength) != 0) {
> ASSERT (Length < PcdGet32 (PcdMaximumAsciiStringLength)); <-- HERE
> }
> }
> return Length;
> }
>
> (Never mind that the comment has a typo -- it incorrectly references
> "PcdMaximumUnicodeStringLength", but the PCD that's actually checked
> is (correctly) "PcdMaximumAsciiStringLength".)
>
> The constant is set to decimal 1,000,000 in ArmVirtQemu builds
> (inherited from MdePkg.dec), and that's indeed a quite unlikely length
> for real-word strings seen by firmware.
>
> I'll take a closer look once I have access to a 32-bit ARM host, but
> I'll definitely need help. Basically we should compare the original
> AARCH64 (dis)assembly with the QEMU-generated 32-bit ARM assembly.
> Hopefully I can at least get a backtrace myself.
I have narrowed down the issue sufficiently that I think I can hand it
over to Peter and Ard now -- because they know AARCH32 and AARCH64
assembly, and "target/arm/translate-a64.c" and "tcg/arm/*" too.
The summarize the issue for Ard, the symptom is that AARCH64 ArmVirtQemu
runs perfectly fine with TCG on an x86-64 system, but it crashes on an
AARCH32 host system.
Below is my analysis.
(1) First, I determined a backtrace for the crash. For this, I flipped
the ASSERT() failure disposition from CpuDeadLoop() to CpuBreakpoint(),
via "PcdDebugPropertyMask". This printed a very nice
Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes
On 05/23/19 02:51, Laszlo Ersek wrote:
> I'm attaching the two log sections ("good.txt" (from
> the x86-64 host) vs "bad.txt" (from the aarch64 host)).
Typo correction: "bad.txt" comes from an aarch32 host. (That's quite the
point.)
Thanks & sorry
Laszlo
Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes
On Wed, 22 May 2019 at 15:22, Laszlo Ersek wrote: > This is very interesting. I had obviously tested booting > "bios-tables-test.aarch64.iso.qcow2" against "edk2-aarch64-code.fd", > using TCG, on my x86_64 laptop. (And, I've run the above exact command > just now, at commit a4f667b67149 -- it works 100% fine.) > > However, I've never been *near* a 32-bit ARM host. Therefore my > suspicion is that the AARCH64 UEFI guest code tickles something in the > 32-bit ARM code generator. It could be a bug in 32-bit ARM TCG, or it > could be a bug in edk2 that is exposed by 32-bit ARM TCG. Does it repro in a 32-bit-chroot in an aarch64 host ? I don't know if that might be easier for you to set up than getting access to real 32-bit hardware. thanks -- PMM
Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes
On 05/22/19 15:06, Igor Mammedov wrote:
> On Tue, 21 May 2019 09:26:16 -0400
> "Michael S. Tsirkin" wrote:
>
>> On Tue, May 21, 2019 at 12:49:48PM +0100, Peter Maydell wrote:
>>> On Tue, 21 May 2019 at 00:10, Michael S. Tsirkin wrote:
The following changes since commit
2259637b95bef3116cc262459271de08e038cc66:
Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into
staging (2019-05-20 17:22:05 +0100)
are available in the Git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
for you to fetch changes up to 0c05ec64c388aea59facbef740651afa78e04f50:
tests: acpi: print error unable to dump ACPI table during rebuild
(2019-05-20 18:40:02 -0400)
pci, pc, virtio: features, fixes
reconnect for vhost blk
tests for UEFI
misc other stuff
Signed-off-by: Michael S. Tsirkin
>>>
>>> Hi -- this failed 'make check' for 32-bit Arm hosts:
>>>
>>> ERROR:/home/peter.maydell/qemu/tests/acpi-utils.c:145:acpi_find_rsdp_address_uefi:
>>> code should not be reached
>>> Aborted
>>> ERROR - too few tests run (expected 1, got 0)
>>> /home/peter.maydell/qemu/tests/Makefile.include:885: recipe for target
>>> 'check-qtest-aarch64' failed
>>>
>>> thanks
>>> -- PMM
>>
>> Nothing jumps out ... Igor?
> On 32-bit ARM host and it looks like UEFI crashes (CCing Laszlo) with:
>
> InstallProtocolInterface: 5B1B31A1-9562-11D2-8E3F-00A0C969723B 469E52C0
> ASSERT [DxeCore]
> /home/lacos/src/upstream/qemu/roms/edk2/MdePkg/Library/BaseLib/String.c(1090):
> Length < _gPcd_FixedAtBuild_PcdMaximumAsciiStringLength
>
> CLI to reproduce:
>
> qemu-system-aarch64 -display none -machine virt,accel=tcg -nodefaults
> -nographic -drive
> if=pflash,format=raw,file=pc-bios/edk2-aarch64-code.fd,readonly -drive
> if=pflash,format=raw,file=pc-bios/edk2-arm-vars.fd,snapshot=on -cdrom
> tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.qcow2 -cpu
> cortex-a57 -serial stdio
This is very interesting. I had obviously tested booting
"bios-tables-test.aarch64.iso.qcow2" against "edk2-aarch64-code.fd",
using TCG, on my x86_64 laptop. (And, I've run the above exact command
just now, at commit a4f667b67149 -- it works 100% fine.)
However, I've never been *near* a 32-bit ARM host. Therefore my
suspicion is that the AARCH64 UEFI guest code tickles something in the
32-bit ARM code generator. It could be a bug in 32-bit ARM TCG, or it
could be a bug in edk2 that is exposed by 32-bit ARM TCG.
The direct assertion failure is mostly useless. The AsciiStrLen()
function does what you'd expect it to, except it has a kind of "safety
check" where it trips an assertion if the string length (under
measurement) exceeds a pre-set platform constant. It helps with catching
memory corruption errors.
$ git show edk2-stable201903:MdePkg/Library/BaseLib/String.c | less
1090g
UINTN
EFIAPI
AsciiStrLen (
IN CONST CHAR8 *String
)
{
UINTN Length;
ASSERT (String != NULL);
for (Length = 0; *String != '\0'; String++, Length++) {
//
// If PcdMaximumUnicodeStringLength is not zero,
// length should not more than PcdMaximumUnicodeStringLength
//
if (PcdGet32 (PcdMaximumAsciiStringLength) != 0) {
ASSERT (Length < PcdGet32 (PcdMaximumAsciiStringLength)); <-- HERE
}
}
return Length;
}
(Never mind that the comment has a typo -- it incorrectly references
"PcdMaximumUnicodeStringLength", but the PCD that's actually checked is
(correctly) "PcdMaximumAsciiStringLength".)
The constant is set to decimal 1,000,000 in ArmVirtQemu builds
(inherited from MdePkg.dec), and that's indeed a quite unlikely length
for real-word strings seen by firmware.
I'll take a closer look once I have access to a 32-bit ARM host, but
I'll definitely need help. Basically we should compare the original
AARCH64 (dis)assembly with the QEMU-generated 32-bit ARM assembly.
Hopefully I can at least get a backtrace myself.
Thanks,
Laszlo
Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes
On Tue, 21 May 2019 09:26:16 -0400 "Michael S. Tsirkin" wrote: > On Tue, May 21, 2019 at 12:49:48PM +0100, Peter Maydell wrote: > > On Tue, 21 May 2019 at 00:10, Michael S. Tsirkin wrote: > > > > > > The following changes since commit > > > 2259637b95bef3116cc262459271de08e038cc66: > > > > > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into > > > staging (2019-05-20 17:22:05 +0100) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > > > > > for you to fetch changes up to 0c05ec64c388aea59facbef740651afa78e04f50: > > > > > > tests: acpi: print error unable to dump ACPI table during rebuild > > > (2019-05-20 18:40:02 -0400) > > > > > > > > > pci, pc, virtio: features, fixes > > > > > > reconnect for vhost blk > > > tests for UEFI > > > misc other stuff > > > > > > Signed-off-by: Michael S. Tsirkin > > > > > > > > > > Hi -- this failed 'make check' for 32-bit Arm hosts: > > > > ERROR:/home/peter.maydell/qemu/tests/acpi-utils.c:145:acpi_find_rsdp_address_uefi: > > code should not be reached > > Aborted > > ERROR - too few tests run (expected 1, got 0) > > /home/peter.maydell/qemu/tests/Makefile.include:885: recipe for target > > 'check-qtest-aarch64' failed > > > > thanks > > -- PMM > > Nothing jumps out ... Igor? On 32-bit ARM host and it looks like UEFI crashes (CCing Laszlo) with: InstallProtocolInterface: 5B1B31A1-9562-11D2-8E3F-00A0C969723B 469E52C0 ASSERT [DxeCore] /home/lacos/src/upstream/qemu/roms/edk2/MdePkg/Library/BaseLib/String.c(1090): Length < _gPcd_FixedAtBuild_PcdMaximumAsciiStringLength CLI to reproduce: qemu-system-aarch64 -display none -machine virt,accel=tcg -nodefaults -nographic -drive if=pflash,format=raw,file=pc-bios/edk2-aarch64-code.fd,readonly -drive if=pflash,format=raw,file=pc-bios/edk2-arm-vars.fd,snapshot=on -cdrom tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.qcow2 -cpu cortex-a57 -serial stdio
Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes
On Tue, 21 May 2019 at 14:42, Michael S. Tsirkin wrote: > > On Tue, May 21, 2019 at 12:49:48PM +0100, Peter Maydell wrote: > > On Tue, 21 May 2019 at 00:10, Michael S. Tsirkin wrote: > > > > > > The following changes since commit > > > 2259637b95bef3116cc262459271de08e038cc66: > > > > > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into > > > staging (2019-05-20 17:22:05 +0100) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > > > > > for you to fetch changes up to 0c05ec64c388aea59facbef740651afa78e04f50: > > > > > > tests: acpi: print error unable to dump ACPI table during rebuild > > > (2019-05-20 18:40:02 -0400) > > > > > > > > > pci, pc, virtio: features, fixes > > > > > > reconnect for vhost blk > > > tests for UEFI > > > misc other stuff > > > > > > Signed-off-by: Michael S. Tsirkin > > > > > > > > > > Hi -- this failed 'make check' for 32-bit Arm hosts: > > > > ERROR:/home/peter.maydell/qemu/tests/acpi-utils.c:145:acpi_find_rsdp_address_uefi: > > code should not be reached > > Aborted > > ERROR - too few tests run (expected 1, got 0) > > /home/peter.maydell/qemu/tests/Makefile.include:885: recipe for target > > 'check-qtest-aarch64' failed > > > > thanks > > -- PMM > > Dropped ARM and re-pushed. Fixed up version applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.1 for any user-visible changes. -- PMM
Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes
On Tue, May 21, 2019 at 12:49:48PM +0100, Peter Maydell wrote: > On Tue, 21 May 2019 at 00:10, Michael S. Tsirkin wrote: > > > > The following changes since commit 2259637b95bef3116cc262459271de08e038cc66: > > > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into > > staging (2019-05-20 17:22:05 +0100) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > > > for you to fetch changes up to 0c05ec64c388aea59facbef740651afa78e04f50: > > > > tests: acpi: print error unable to dump ACPI table during rebuild > > (2019-05-20 18:40:02 -0400) > > > > > > pci, pc, virtio: features, fixes > > > > reconnect for vhost blk > > tests for UEFI > > misc other stuff > > > > Signed-off-by: Michael S. Tsirkin > > > > > > Hi -- this failed 'make check' for 32-bit Arm hosts: > > ERROR:/home/peter.maydell/qemu/tests/acpi-utils.c:145:acpi_find_rsdp_address_uefi: > code should not be reached > Aborted > ERROR - too few tests run (expected 1, got 0) > /home/peter.maydell/qemu/tests/Makefile.include:885: recipe for target > 'check-qtest-aarch64' failed > > thanks > -- PMM Dropped ARM and re-pushed. -- MST
Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes
On Tue, May 21, 2019 at 12:49:48PM +0100, Peter Maydell wrote: > On Tue, 21 May 2019 at 00:10, Michael S. Tsirkin wrote: > > > > The following changes since commit 2259637b95bef3116cc262459271de08e038cc66: > > > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into > > staging (2019-05-20 17:22:05 +0100) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > > > for you to fetch changes up to 0c05ec64c388aea59facbef740651afa78e04f50: > > > > tests: acpi: print error unable to dump ACPI table during rebuild > > (2019-05-20 18:40:02 -0400) > > > > > > pci, pc, virtio: features, fixes > > > > reconnect for vhost blk > > tests for UEFI > > misc other stuff > > > > Signed-off-by: Michael S. Tsirkin > > > > > > Hi -- this failed 'make check' for 32-bit Arm hosts: > > ERROR:/home/peter.maydell/qemu/tests/acpi-utils.c:145:acpi_find_rsdp_address_uefi: > code should not be reached > Aborted > ERROR - too few tests run (expected 1, got 0) > /home/peter.maydell/qemu/tests/Makefile.include:885: recipe for target > 'check-qtest-aarch64' failed > > thanks > -- PMM OK for now I will just drop UEFI tests from ARM. Igor will debug and re-add later on. Igor, as you do this maybe start by adding the infrastructure with the blacklist so we can formalize the current "these tables need to be updated". -- MST
Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes
On Tue, May 21, 2019 at 12:49:48PM +0100, Peter Maydell wrote: > On Tue, 21 May 2019 at 00:10, Michael S. Tsirkin wrote: > > > > The following changes since commit 2259637b95bef3116cc262459271de08e038cc66: > > > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into > > staging (2019-05-20 17:22:05 +0100) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > > > for you to fetch changes up to 0c05ec64c388aea59facbef740651afa78e04f50: > > > > tests: acpi: print error unable to dump ACPI table during rebuild > > (2019-05-20 18:40:02 -0400) > > > > > > pci, pc, virtio: features, fixes > > > > reconnect for vhost blk > > tests for UEFI > > misc other stuff > > > > Signed-off-by: Michael S. Tsirkin > > > > > > Hi -- this failed 'make check' for 32-bit Arm hosts: > > ERROR:/home/peter.maydell/qemu/tests/acpi-utils.c:145:acpi_find_rsdp_address_uefi: > code should not be reached > Aborted > ERROR - too few tests run (expected 1, got 0) > /home/peter.maydell/qemu/tests/Makefile.include:885: recipe for target > 'check-qtest-aarch64' failed > > thanks > -- PMM Nothing jumps out ... Igor? -- MST
Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes
On Tue, 21 May 2019 at 00:10, Michael S. Tsirkin wrote: > > The following changes since commit 2259637b95bef3116cc262459271de08e038cc66: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2019-05-20 17:22:05 +0100) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > for you to fetch changes up to 0c05ec64c388aea59facbef740651afa78e04f50: > > tests: acpi: print error unable to dump ACPI table during rebuild > (2019-05-20 18:40:02 -0400) > > > pci, pc, virtio: features, fixes > > reconnect for vhost blk > tests for UEFI > misc other stuff > > Signed-off-by: Michael S. Tsirkin > > Hi -- this failed 'make check' for 32-bit Arm hosts: ERROR:/home/peter.maydell/qemu/tests/acpi-utils.c:145:acpi_find_rsdp_address_uefi: code should not be reached Aborted ERROR - too few tests run (expected 1, got 0) /home/peter.maydell/qemu/tests/Makefile.include:885: recipe for target 'check-qtest-aarch64' failed thanks -- PMM
