Re: [Qemu-devel] [PULL v2 21/50] Makefile: add target to print generated files
"Michael S. Tsirkin" writes: > On Fri, Apr 13, 2018 at 12:04:20PM +0200, Marc-André Lureau wrote: >> Hi >> >> On Fri, Apr 13, 2018 at 9:21 AM, Markus Armbruster wrote: >> > "Michael S. Tsirkin" writes: >> > >> >> This is helpful for automatic code analysis. >> > >> > Out of curiosity: how? >> > >> >> Signed-off-by: Michael S. Tsirkin >> >> --- >> >> Makefile | 3 +++ >> >> 1 file changed, 3 insertions(+) >> >> >> >> diff --git a/Makefile b/Makefile >> >> index 677a54b..f799390 100644 >> >> --- a/Makefile >> >> +++ b/Makefile >> >> @@ -1045,6 +1045,9 @@ endif >> >> include $(SRC_PATH)/tests/docker/Makefile.include >> >> include $(SRC_PATH)/tests/vm/Makefile.include >> >> >> >> +printgen: >> >> + @echo $(GENERATED_FILES) >> >> + >> >> .PHONY: help >> >> help: >> >> @echo 'Generic targets:' >> > >> > I tried to answer my question myself by looking up the thread where this >> > patch was posted for review. I can't find any. Am I blind? > > That was a development patch that sneaked in. Sorry. I'll revert. Since you haven't, I took the liberty to post the revert myself. >> And you could also "make print-GENERATED_FILES" already > > Nice tip, thanks for that.
Re: [Qemu-devel] [PULL v2 21/50] Makefile: add target to print generated files
On Fri, Apr 13, 2018 at 12:04:20PM +0200, Marc-André Lureau wrote: > Hi > > On Fri, Apr 13, 2018 at 9:21 AM, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > >> This is helpful for automatic code analysis. > > > > Out of curiosity: how? > > > >> Signed-off-by: Michael S. Tsirkin > >> --- > >> Makefile | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/Makefile b/Makefile > >> index 677a54b..f799390 100644 > >> --- a/Makefile > >> +++ b/Makefile > >> @@ -1045,6 +1045,9 @@ endif > >> include $(SRC_PATH)/tests/docker/Makefile.include > >> include $(SRC_PATH)/tests/vm/Makefile.include > >> > >> +printgen: > >> + @echo $(GENERATED_FILES) > >> + > >> .PHONY: help > >> help: > >> @echo 'Generic targets:' > > > > I tried to answer my question myself by looking up the thread where this > > patch was posted for review. I can't find any. Am I blind? That was a development patch that sneaked in. Sorry. I'll revert. > > And you could also "make print-GENERATED_FILES" already Nice tip, thanks for that. -- MST
Re: [Qemu-devel] [PULL v2 21/50] Makefile: add target to print generated files
Hi On Fri, Apr 13, 2018 at 9:21 AM, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > >> This is helpful for automatic code analysis. > > Out of curiosity: how? > >> Signed-off-by: Michael S. Tsirkin >> --- >> Makefile | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Makefile b/Makefile >> index 677a54b..f799390 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -1045,6 +1045,9 @@ endif >> include $(SRC_PATH)/tests/docker/Makefile.include >> include $(SRC_PATH)/tests/vm/Makefile.include >> >> +printgen: >> + @echo $(GENERATED_FILES) >> + >> .PHONY: help >> help: >> @echo 'Generic targets:' > > I tried to answer my question myself by looking up the thread where this > patch was posted for review. I can't find any. Am I blind? And you could also "make print-GENERATED_FILES" already
Re: [Qemu-devel] [PULL v2 21/50] Makefile: add target to print generated files
"Michael S. Tsirkin" writes: > This is helpful for automatic code analysis. Out of curiosity: how? > Signed-off-by: Michael S. Tsirkin > --- > Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Makefile b/Makefile > index 677a54b..f799390 100644 > --- a/Makefile > +++ b/Makefile > @@ -1045,6 +1045,9 @@ endif > include $(SRC_PATH)/tests/docker/Makefile.include > include $(SRC_PATH)/tests/vm/Makefile.include > > +printgen: > + @echo $(GENERATED_FILES) > + > .PHONY: help > help: > @echo 'Generic targets:' I tried to answer my question myself by looking up the thread where this patch was posted for review. I can't find any. Am I blind?
