Re: [Qemu-devel] [Qemu-arm] [PATCH v4 5/6] loader: Implement .hex file loader

2018-08-16 Thread Philippe Mathieu-Daudé
On 08/15/2018 02:52 PM, Stefan Hajnoczi wrote: > On Wed, Aug 15, 2018 at 3:18 PM Philippe Mathieu-Daudé > wrote: >> On 08/13/2018 12:56 PM, Stefan Hajnoczi wrote: >>> On Fri, Aug 10, 2018 at 02:00:44AM -0300, Philippe Mathieu-Daudé wrote: On 08/03/2018 11:47 AM, Stefan Hajnoczi wrote: >

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 5/6] loader: Implement .hex file loader

2018-08-15 Thread Stefan Hajnoczi
On Wed, Aug 15, 2018 at 3:18 PM Philippe Mathieu-Daudé wrote: > On 08/13/2018 12:56 PM, Stefan Hajnoczi wrote: > > On Fri, Aug 10, 2018 at 02:00:44AM -0300, Philippe Mathieu-Daudé wrote: > >> On 08/03/2018 11:47 AM, Stefan Hajnoczi wrote: > >>> +parser->rom_start_address =

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 5/6] loader: Implement .hex file loader

2018-08-15 Thread Philippe Mathieu-Daudé
On 08/13/2018 12:56 PM, Stefan Hajnoczi wrote: > On Fri, Aug 10, 2018 at 02:00:44AM -0300, Philippe Mathieu-Daudé wrote: >> On 08/03/2018 11:47 AM, Stefan Hajnoczi wrote: >>> +parser->rom_start_address = parser->next_address_to_write; >>> +parser->current_rom_index = 0; >>> +

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 5/6] loader: Implement .hex file loader

2018-08-13 Thread Stefan Hajnoczi
On Fri, Aug 10, 2018 at 02:00:44AM -0300, Philippe Mathieu-Daudé wrote: > On 08/03/2018 11:47 AM, Stefan Hajnoczi wrote: > > +parser->rom_start_address = parser->next_address_to_write; > > +parser->current_rom_index = 0; > > +break; > > + > > +case

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 5/6] loader: Implement .hex file loader

2018-08-10 Thread sail darcy
Thanks for your suggestion, I will review your comments carefully and take modification in the next patch. Best, SU Hang Philippe Mathieu-Daudé 于2018年8月10日周五 下午3:19写道: > Hi Su, > > On 08/03/2018 11:47 AM, Stefan Hajnoczi wrote: > > From: Su Hang > > > > This patch adds Intel Hexadecimal

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 5/6] loader: Implement .hex file loader

2018-08-09 Thread Philippe Mathieu-Daudé
Hi Su, On 08/03/2018 11:47 AM, Stefan Hajnoczi wrote: > From: Su Hang > > This patch adds Intel Hexadecimal Object File format support to the > generic loader device. The file format specification is available here: > http://www.piclist.com/techref/fileext/hex/intel.htm > > This file format